Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 1098303002: Fix crash on Enrollment screen. (Closed)

Created:
5 years, 8 months ago by Ivan Podogov
Modified:
5 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on Enrollment screen. This is a sequel to crbug/470977, with a similar cause. This time, crash is induced by WizardController re-creation, so the old NetworkErrorModel pointers become invalid. Lesson learned: WizardController should NOT be the owner of an ErrorScreen instance. BUG=479666 Committed: https://crrev.com/97422a9583d83ea837f889a2e23adb157092f9ae Cr-Commit-Position: refs/heads/master@{#326317}

Patch Set 1 #

Patch Set 2 : Fix test compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -38 lines) Patch
M chrome/browser/chromeos/login/screen_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ivan Podogov
PTAL
5 years, 8 months ago (2015-04-22 14:42:57 UTC) #2
Nikita (slow)
lgtm
5 years, 8 months ago (2015-04-22 14:48:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098303002/1
5 years, 8 months ago (2015-04-22 14:49:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/29802)
5 years, 8 months ago (2015-04-22 15:37:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098303002/20001
5 years, 8 months ago (2015-04-22 15:52:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-22 16:55:53 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 16:56:51 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/97422a9583d83ea837f889a2e23adb157092f9ae
Cr-Commit-Position: refs/heads/master@{#326317}

Powered by Google App Engine
This is Rietveld 408576698