runtime/vm/flow_graph_allocator.cc - Issue 10983024: Disregard constants with no SSA temp index in register allocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 10983024: Disregard constants with no SSA temp index in register allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_allocator.cc

diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc

index ea27ce58d814550e39e6dbffa82a55012e4e7fe2..1e0cb4f1dfb8cb67253aebd0392ea070616a1c2e 100644

--- a/runtime/vm/flow_graph_allocator.cc

+++ b/runtime/vm/flow_graph_allocator.cc

@@ -787,7 +787,8 @@ void FlowGraphAllocator::ProcessOneInstruction(BlockEntryInstr* block,

Definition* def = current->AsDefinition();

if ((def != NULL) &&

(def->AsConstant() != NULL) &&

- (GetLiveRange(def->ssa_temp_index())->first_use() == NULL)) {

+ ((def->ssa_temp_index() == -1) ||

+ (GetLiveRange(def->ssa_temp_index())->first_use() == NULL))) {

// Drop definitions of constants that have no uses.

locs->set_out(Location::NoLocation());

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »