Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: Source/core/svg/SVGViewSpec.h

Issue 1098273002: Fix SVG animations for preserveAspectRatio attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Modified the test case for visual difference. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/animations/viewspec-checkaspectparams-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGViewSpec.h
diff --git a/Source/core/svg/SVGViewSpec.h b/Source/core/svg/SVGViewSpec.h
index 1d078452e18358db31fcfc8b7590433bc5978bbc..59e022397c95df358f208e1aa204e1c64a04bc2f 100644
--- a/Source/core/svg/SVGViewSpec.h
+++ b/Source/core/svg/SVGViewSpec.h
@@ -80,7 +80,7 @@ void SVGViewSpec::inheritViewAttributesFromElement(T* inheritFromElement)
if (!inheritFromElement->hasEmptyViewBox())
viewBox()->baseValue()->setValue(inheritFromElement->viewBox()->currentValue()->value());
- if (inheritFromElement->hasAttribute(SVGNames::preserveAspectRatioAttr)) {
+ if (inheritFromElement->preserveAspectRatio()->isSpecified()) {
preserveAspectRatio()->baseValue()->setAlign(inheritFromElement->preserveAspectRatio()->currentValue()->align());
preserveAspectRatio()->baseValue()->setMeetOrSlice(inheritFromElement->preserveAspectRatio()->currentValue()->meetOrSlice());
}
« no previous file with comments | « LayoutTests/svg/animations/viewspec-checkaspectparams-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698