Source/core/svg/SVGViewSpec.h - Issue 1098273002: Fix SVG animations for preserveAspectRatio attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGViewSpec.h

Issue 1098273002: Fix SVG animations for preserveAspectRatio attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGViewSpec.h

diff --git a/Source/core/svg/SVGViewSpec.h b/Source/core/svg/SVGViewSpec.h

index c4a393eab97c355924da48e86a69952ce9fd0283..1e6a464a2b6b357f342298e7a6a9aac022bceb0a 100644

--- a/Source/core/svg/SVGViewSpec.h

+++ b/Source/core/svg/SVGViewSpec.h

@@ -80,7 +80,7 @@ void SVGViewSpec::inheritViewAttributesFromElement(T* inheritFromElement)

if (inheritFromElement->hasAttribute(SVGNames::viewBoxAttr))

viewBox()->baseValue()->setValue(inheritFromElement->viewBox()->currentValue()->value());

- if (inheritFromElement->hasAttribute(SVGNames::preserveAspectRatioAttr)) {

+ if (inheritFromElement->preserveAspectRatio()->currentValue()->align() != SVGPreserveAspectRatio::SVG_PRESERVEASPECTRATIO_UNKNOWN && inheritFromElement->preserveAspectRatio()->currentValue()->meetOrSlice() != SVGPreserveAspectRatio::SVG_MEETORSLICE_UNKNOWN) {

fs 2015/04/23 08:30:32 I believe what you want here is inheritFromElement

preserveAspectRatio()->baseValue()->setAlign(inheritFromElement->preserveAspectRatio()->currentValue()->align());

preserveAspectRatio()->baseValue()->setMeetOrSlice(inheritFromElement->preserveAspectRatio()->currentValue()->meetOrSlice());

}

« no previous file with comments | « LayoutTests/svg/animations/viewspec-checkaspectparams-expected.html ('k') | no next file » | no next file with comments »