Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Issue 1098243003: java libraries: Fix warnings in eclipse. (Closed)

Created:
5 years, 8 months ago by qsr
Modified:
5 years, 8 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -390 lines) Patch
M services/keyboard/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
D services/keyboard/org/chromium/mojo/keyboard/InputConnectionAdaptor.java View 1 chunk +0 lines, -76 lines 0 comments Download
D services/keyboard/org/chromium/mojo/keyboard/KeyboardServiceImpl.java View 1 chunk +0 lines, -82 lines 0 comments Download
A + services/keyboard/src/org/chromium/mojo/keyboard/InputConnectionAdaptor.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/keyboard/src/org/chromium/mojo/keyboard/KeyboardServiceImpl.java View 3 chunks +2 lines, -10 lines 0 comments Download
M services/sensors/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
D services/sensors/org/chromium/mojo/sensors/SensorForwarder.java View 1 chunk +0 lines, -111 lines 0 comments Download
D services/sensors/org/chromium/mojo/sensors/SensorServiceImpl.java View 1 chunk +0 lines, -36 lines 0 comments Download
D services/sensors/org/chromium/mojo/sensors/Sensors.java View 1 chunk +0 lines, -64 lines 0 comments Download
A + services/sensors/src/org/chromium/mojo/sensors/SensorForwarder.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/sensors/src/org/chromium/mojo/sensors/SensorServiceImpl.java View 2 chunks +1 line, -4 lines 0 comments Download
A + services/sensors/src/org/chromium/mojo/sensors/Sensors.java View 1 chunk +1 line, -1 line 0 comments Download
M shell/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/Keyboard.java View 2 chunks +4 lines, -1 line 0 comments Download
M sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
qsr
5 years, 8 months ago (2015-04-22 11:32:33 UTC) #1
ppi
lgtm, trybots maybe?
5 years, 8 months ago (2015-04-22 11:47:07 UTC) #2
qsr
5 years, 8 months ago (2015-04-22 11:59:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56e1705be817cbc91f74005b897cbc8c38d5f4d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698