Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1098243002: Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #1 id:1 of https://codereview.chromium.org/1103473003/) Reason for revert: This was probably an infrastructure problem caused by the mac ninja/goma switch. Original issue's description: > Revert of [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) (patchset #7 id:140001 of https://codereview.chromium.org/1011823003/) > > Reason for revert: > [Sheriff] breaks mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1029 > > Original issue's description: > > [es6] don't throw if argument is non-object (O.freeze, O.seal, O.preventExtensions) > > > > BUG=v8:3965, v8:3966 > > R=arv@chromium.org > > LOG=N > > > > Committed: https://crrev.com/b09c048f693d280052ac63c7d6b3baf27b3bf271 > > Cr-Commit-Position: refs/heads/master@{#27985} > > TBR=arv@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3965, v8:3966 TBR=arv@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3965, v8:3966 Committed: https://crrev.com/6911943e0be0aadf582965b21438b4fe78830c81 Cr-Commit-Position: refs/heads/master@{#27999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -91 lines) Patch
M src/v8natives.js View 6 chunks +6 lines, -18 lines 0 comments Download
M test/mjsunit/messages.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/object-freeze.js View 2 chunks +68 lines, -20 lines 0 comments Download
M test/mjsunit/object-seal.js View 2 chunks +15 lines, -22 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -26 lines 0 comments Download
M test/test262/test262.status View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Michael Achenbach
5 years, 8 months ago (2015-04-22 10:33:36 UTC) #1
Created Revert of Revert of [es6] don't throw if argument is non-object
(O.freeze, O.seal, O.preventExtensions)

Powered by Google App Engine
This is Rietveld 408576698