Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: src/effects/SkBlurMaskFilter.cpp

Issue 109823012: Pass ctm when performing image filtering in GPU backend. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: remove bmp version of filter func Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/effects/SkBlurMaskFilter.cpp
diff --git a/src/effects/SkBlurMaskFilter.cpp b/src/effects/SkBlurMaskFilter.cpp
index d2c43d719bcd707ddd58a3adacfe27b6a1015476..81eaa29a6db2a71a63cd5c1706b55695c26b7c16 100644
--- a/src/effects/SkBlurMaskFilter.cpp
+++ b/src/effects/SkBlurMaskFilter.cpp
@@ -38,9 +38,10 @@ public:
const SkMatrix& ctm,
SkRect* maskRect) const SK_OVERRIDE;
virtual bool filterMaskGPU(GrTexture* src,
+ const SkMatrix& ctm,
const SkRect& maskRect,
GrTexture** result,
- bool canOverwriteSrc) const;
+ bool canOverwriteSrc) const SK_OVERRIDE;
#endif
virtual void computeFastBounds(const SkRect&, SkRect*) const SK_OVERRIDE;
@@ -540,15 +541,17 @@ bool SkBlurMaskFilterImpl::canFilterMaskGPU(const SkRect& srcBounds,
}
bool SkBlurMaskFilterImpl::filterMaskGPU(GrTexture* src,
robertphillips 2014/01/08 20:15:18 Move the following lines right 1 space?
bsalomon 2014/01/08 21:38:36 Done.
- const SkRect& maskRect,
- GrTexture** result,
- bool canOverwriteSrc) const {
+ const SkMatrix& matrix,
+ const SkRect& maskRect,
+ GrTexture** result,
+ bool canOverwriteSrc) const {
SkRect clipRect = SkRect::MakeWH(maskRect.width(), maskRect.height());
GrContext* context = src->getContext();
GrContext::AutoWideOpenIdentityDraw awo(context, NULL);
+ // FIXME: This isn't the right matrix.
SkScalar xformedSigma = this->computeXformedSigma(context->getMatrix());
SkASSERT(xformedSigma > 0);

Powered by Google App Engine
This is Rietveld 408576698