Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1098223004: Revert of Always optimize for adding properties to native objects. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Always optimize for adding properties to native objects. (patchset #1 id:1 of https://codereview.chromium.org/1094383004/) Reason for revert: GC stress failure (custom snapshot) Original issue's description: > Always optimize for adding properties to native objects. > > R=jkummerow@chromium.org > > Committed: https://crrev.com/c715098e85b93def76c0b3f54290c811dea04f01 > Cr-Commit-Position: refs/heads/master@{#28003} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/bb6958ceff221e66adbc4581471a8ce1b41a4684 Cr-Commit-Position: refs/heads/master@{#28009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/v8natives.js View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Always optimize for adding properties to native objects.
5 years, 8 months ago (2015-04-22 13:20:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098223004/1
5 years, 8 months ago (2015-04-22 13:21:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 13:23:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bb6958ceff221e66adbc4581471a8ce1b41a4684 Cr-Commit-Position: refs/heads/master@{#28009}
5 years, 8 months ago (2015-04-22 13:24:02 UTC) #4
Yang
5 years, 8 months ago (2015-04-22 14:13:37 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1100123002/ by yangguo@chromium.org.

The reason for reverting is: Test failure was not due to this..

Powered by Google App Engine
This is Rietveld 408576698