Issue 10982093: Merge 129397 - MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10982093: Merge 129397 - MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded … (Closed)

Created:
8 years, 2 months ago by karen

Modified:
8 years, 2 months ago

Reviewers:
tommyw

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Visibility:
Public.

More Reviews

Description

Merge 129397 - MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback https://bugs.webkit.org/show_bug.cgi?id=97456 Reviewed by Adam Barth. Renamed onnegotationneeded to onnegotiationneeded. Source/WebCore: Existing test updated. * Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::negotiationNeeded): * Modules/mediastream/RTCPeerConnection.h: (RTCPeerConnection): * Modules/mediastream/RTCPeerConnection.idl: * dom/EventNames.h: (WebCore): LayoutTests: * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt: * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html: TBR=tommyw@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129926

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/Modules/mediastream/RTCPeerConnection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/Modules/mediastream/RTCPeerConnection.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/dom/EventNames.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages