Issue 10982059: Linux: Blacklist 32-bit Flash 11.2.202.238 when the CPU doesn't support SSE2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10982059: Linux: Blacklist 32-bit Flash 11.2.202.238 when the CPU doesn't support SSE2. (Closed)

Created:
8 years, 2 months ago by Lei Zhang

Modified:
8 years, 2 months ago

Reviewers:
Bernhard Bauer, viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux: Blacklist 32-bit Flash 11.2.202.238 when the CPU doesn't support SSE2. BUG=140086 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=159520

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/plugins/npapi/plugin_list_posix.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

I thought Adobe wasn't going to push new updates on Linux, but here we are. ...

8 years, 2 months ago (2012-09-26 23:40:58 UTC) #1

Bernhard Bauer

LGTM, but… https://codereview.chromium.org/10982059/diff/1/webkit/plugins/npapi/plugin_list_posix.cc File webkit/plugins/npapi/plugin_list_posix.cc (right): https://codereview.chromium.org/10982059/diff/1/webkit/plugins/npapi/plugin_list_posix.cc#newcode80 webkit/plugins/npapi/plugin_list_posix.cc:80: { 17410532, "e9401097e97c8443a7d9156be62184ffe1addd5c", Are we going to ...

8 years, 2 months ago (2012-09-29 07:36:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10982059/1

8 years, 2 months ago (2012-10-01 17:32:19 UTC) #5

commit-bot: I haz the power

8 years, 2 months ago (2012-10-01 17:35:35 UTC) #6

Retried try job too often for step(s) compile

Expand Messages | Collapse Messages