Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 10982030: Revert "Fix invalid locations problem for inline super constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index 1b4f6a87550cba6fe50aecf4dea4170ab663f3b6..6750f6de210305a3ec9da00cd91d7515c6a10d61 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -1166,10 +1166,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
FunctionElement target = elements[call];
Selector selector = elements.getSelector(call);
Link<Node> arguments = call.arguments;
- sourceElementStack.add(target);
inlineSuperOrRedirect(target, selector, arguments, constructors,
fieldValues);
- sourceElementStack.removeLast();
foundSuperOrRedirect = true;
} else {
// A field initializer.
@@ -1198,13 +1196,11 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
if (target === null) {
compiler.internalError("no default constructor available");
}
- sourceElementStack.add(target.implementation);
inlineSuperOrRedirect(target.implementation,
selector,
const EmptyLink<Node>(),
constructors,
fieldValues);
- sourceElementStack.removeLast();
}
}
}
@@ -2301,8 +2297,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
typeInfo = pop();
}
if (type.element.isTypeVariable()) {
- // TODO(karlklose): We currently answer true to any is check
- // involving a type variable -- both is T and is !T -- until
+ // TODO(karlklose): We currently answer true to any is check
+ // involving a type variable -- both is T and is !T -- until
// we have a proper implementation of reified generics.
stack.add(graph.addConstantBool(true, constantSystem));
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698