Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10982007: Merge 157914 - Fix toolbar keyboard accessibility on Views (alternative impl). (Closed)

Created:
8 years, 3 months ago by dmazzoni
Modified:
8 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Merge 157914 - Fix toolbar keyboard accessibility on Views (alternative impl). This broke when the location bar got moved out of the toolbar's view hierarchy, it no longer became possible to tab through all of the controls in the toolbar including the location bar. To fix this, I have AccessiblePaneView provide its own subclass of FocusSearch, overriding GetParent and Contains so that the location bar is considered to be part of the toolbar for focus searching. Adds a new test that should catch this type of regression in the future, while hopefully not being too brittle so it will still succeed as the toolbar changes over time. BUG=145835 TEST=Press F6 or Alt+Shift+T to focus the toolbar, then Tab to all of the focusable controls, make sure the location bar is included. Review URL: https://chromiumcodereview.appspot.com/10949005 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -22 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_container.h View 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_container.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 5 chunks +23 lines, -1 line 0 comments Download
A + chrome/browser/ui/views/toolbar_view_browsertest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/accessible_pane_view.h View 3 chunks +21 lines, -0 lines 0 comments Download
M ui/views/accessible_pane_view.cc View 6 chunks +40 lines, -4 lines 0 comments Download
M ui/views/accessible_pane_view_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/views/focus/focus_search.h View 2 chunks +12 lines, -4 lines 0 comments Download
M ui/views/focus/focus_search.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmazzoni
8 years, 3 months ago (2012-09-24 21:08:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698