lib/html/src/shared_FactoryProviders.dart - Issue 10982002: Fixing creating SVG elements with trailing newlines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/src/shared_FactoryProviders.dart

Issue 10982002: Fixing creating SVG elements with trailing newlines. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/src/shared_FactoryProviders.dart

diff --git a/lib/html/src/shared_FactoryProviders.dart b/lib/html/src/shared_FactoryProviders.dart

index f5c8abe38dc602aae926db7cf91dc2c072f527ad..146e7a69c12297ed9dfd812b4de8c914be3f1a05 100644

--- a/lib/html/src/shared_FactoryProviders.dart

+++ b/lib/html/src/shared_FactoryProviders.dart

@@ -89,7 +89,7 @@ class _SVGElementFactoryProvider {

}

parentTag.innerHTML = svg;

- if (parentTag.elements.length == 1) return parentTag.nodes.removeLast();

+ if (parentTag.elements.length == 1) return parentTag.elements.removeLast();

throw new IllegalArgumentException(

'SVG had ${parentTag.elements.length} '

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | samples/logo/logo.dart » ('j') | no next file with comments »