Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1098193003: Added Launcher_MinimizeTask UMA user action. (Closed)

Created:
5 years, 8 months ago by bruthig
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added Launcher_MinimizeTask UMA user action. The Launcher_MinimzeTask user action is recorded when the user activates a shelf icon causing a window to be minimized. TEST=ShelfViewTest.Launcher_MinimizeTaskIsRecordedWhenWindowIsMinimized BUG=471358 Committed: https://crrev.com/f29a78fcc51cde6b9a8bd1a00b2c0c2fa799580c Cr-Commit-Position: refs/heads/master@{#326834}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Renamed unit test. #

Patch Set 3 : Rebase on master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M ash/metrics/user_metrics_recorder.h View 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 2 1 chunk +3 lines, -0 lines 0 comments Download
M ash/shelf/shelf_view.cc View 2 2 chunks +4 lines, -1 line 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
bruthig
rkaplow@|asvitkine@: Please review changes in tools/metrics/* oshima@: Please review changes in ash/* Note: This review ...
5 years, 8 months ago (2015-04-21 21:51:44 UTC) #2
oshima
https://codereview.chromium.org/1098193003/diff/1/ash/shelf/shelf_view_unittest.cc File ash/shelf/shelf_view_unittest.cc (right): https://codereview.chromium.org/1098193003/diff/1/ash/shelf/shelf_view_unittest.cc#newcode1846 ash/shelf/shelf_view_unittest.cc:1846: TEST_F(ShelfViewTest, Launcher_MinimizeTaskIsRecordedWhenNewWindowIsCreated) { The name sounds odd. Shouldn't this ...
5 years, 8 months ago (2015-04-21 22:52:15 UTC) #3
bruthig
Fixed incorrect test name. oshima@ can you please have another look at ash/*? https://codereview.chromium.org/1098193003/diff/1/ash/shelf/shelf_view_unittest.cc File ...
5 years, 8 months ago (2015-04-21 23:06:46 UTC) #4
oshima
ash lgtm
5 years, 8 months ago (2015-04-21 23:13:33 UTC) #5
rkaplow
lgtm probably should have mentioned this includes the code from your other CL. This also ...
5 years, 8 months ago (2015-04-22 14:23:43 UTC) #6
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-04-22 15:57:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098193003/20001
5 years, 8 months ago (2015-04-23 13:56:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/60175)
5 years, 8 months ago (2015-04-23 14:00:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098193003/40001
5 years, 8 months ago (2015-04-24 17:09:52 UTC) #14
bruthig
I rebased on master. No need to review.
5 years, 8 months ago (2015-04-24 17:10:53 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-24 18:05:45 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 18:06:29 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f29a78fcc51cde6b9a8bd1a00b2c0c2fa799580c
Cr-Commit-Position: refs/heads/master@{#326834}

Powered by Google App Engine
This is Rietveld 408576698