Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1098123004: Revert of mac: Weakly link against the CoreBluetooth framework. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Weakly link against the CoreBluetooth framework. (patchset #2 id:80001 of https://codereview.chromium.org/1101513003/) Reason for revert: Looks like this broke the Mac GN build: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN%20(dbg)/builds/8764 device/BUILD.gn needs to include //build/config/mac/mac_sdk.gni , I think. Original issue's description: > mac: Weakly link against the CoreBluetooth framework. > > In the OSX 10.10 SDK, CoreBluetooth became a top level framework. Previously, > it was nested in IOBluetooth. In order for Chrome to run on OSes older than OSX > 10.10, the top level CoreBluetooth framework must be weakly linked. > > BUG=463170 > > Committed: https://crrev.com/9fde3e00865650009c7e85fcb7157719372b97a8 > Cr-Commit-Position: refs/heads/master@{#326705} TBR=rsesek@chromium.org,keybuk@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463170

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M device/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dirk Pranke
Created Revert of mac: Weakly link against the CoreBluetooth framework.
5 years, 8 months ago (2015-04-24 01:06:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098123004/1
5 years, 8 months ago (2015-04-24 01:07:00 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 8 months ago (2015-04-24 01:07:58 UTC) #4
Dirk Pranke
5 years, 8 months ago (2015-04-24 01:11:02 UTC) #6
Message was sent while issue was closed.
On 2015/04/24 01:07:58, I haz the power (commit-bot) wrote:
> Failed to apply the patch.

Already reverted, apparently. Closing.

Powered by Google App Engine
This is Rietveld 408576698