Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1098093003: fix some small bugs with GrAtlasTextContext (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix some small bugs with GrAtlasTextContext BUG=skia: Committed: https://skia.googlesource.com/skia/+/a7c6389ebf19cf58926f7a1616f0e5554c56aa84

Patch Set 1 #

Patch Set 2 : other tiny fix #

Total comments: 1

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-21 19:20:59 UTC) #2
bsalomon
lgtm
5 years, 8 months ago (2015-04-21 20:13:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098093003/20001
5 years, 8 months ago (2015-04-21 20:17:00 UTC) #5
jvanverth1
https://codereview.chromium.org/1098093003/diff/20001/src/gpu/GrAtlasTextContext.cpp File src/gpu/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1098093003/diff/20001/src/gpu/GrAtlasTextContext.cpp#newcode54 src/gpu/GrAtlasTextContext.cpp:54: static const int kLargeDFFontLimit = 2 * kLargeDFFontSize; Not ...
5 years, 8 months ago (2015-04-21 20:17:04 UTC) #6
joshualitt
On 2015/04/21 20:17:04, jvanverth1 wrote: > https://codereview.chromium.org/1098093003/diff/20001/src/gpu/GrAtlasTextContext.cpp > File src/gpu/GrAtlasTextContext.cpp (right): > > https://codereview.chromium.org/1098093003/diff/20001/src/gpu/GrAtlasTextContext.cpp#newcode54 > ...
5 years, 8 months ago (2015-04-21 20:19:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1098093003/40001
5 years, 8 months ago (2015-04-21 20:19:27 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 20:24:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a7c6389ebf19cf58926f7a1616f0e5554c56aa84

Powered by Google App Engine
This is Rietveld 408576698