chrome/browser/history/history_backend_unittest.cc - Issue 1098053003: Expire favicon bitmaps when merging from sync and clearing browser history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 1098053003: Expire favicon bitmaps when merging from sync and clearing browser history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_unittest.cc ('k') | chrome/browser/history/thumbnail_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_backend_unittest.cc

diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc

index 771a0fff8251a8709c9c06fb12a0ad7e99164a10..308b9fd98bbfaab5935e8f622fcd4638dc032e0a 100644

--- a/chrome/browser/history/history_backend_unittest.cc

+++ b/chrome/browser/history/history_backend_unittest.cc

@@ -2044,7 +2044,7 @@ TEST_F(HistoryBackendTest, MergeFaviconPageURLNotInDB) {

EXPECT_EQ(icon_url, icon_mappings[0].icon_url);

EXPECT_TRUE(GetOnlyFaviconBitmap(icon_mappings[0].icon_id, &favicon_bitmap));

- EXPECT_NE(base::Time(), favicon_bitmap.last_updated);

+ EXPECT_EQ(base::Time(), favicon_bitmap.last_updated);

EXPECT_TRUE(BitmapDataEqual('b', favicon_bitmap.bitmap_data));

EXPECT_EQ(kSmallSize, favicon_bitmap.pixel_size);

}

@@ -2112,7 +2112,7 @@ TEST_F(HistoryBackendTest, MergeFaviconPageURLInDB) {

EXPECT_EQ(icon_url1, icon_mappings[0].icon_url);

EXPECT_TRUE(GetOnlyFaviconBitmap(icon_mappings[0].icon_id, &favicon_bitmap));

- EXPECT_NE(base::Time(), favicon_bitmap.last_updated);

+ EXPECT_EQ(base::Time(), favicon_bitmap.last_updated);

EXPECT_TRUE(BitmapDataEqual('b', favicon_bitmap.bitmap_data));

EXPECT_EQ(kSmallSize, favicon_bitmap.pixel_size);

@@ -2230,7 +2230,7 @@ TEST_F(HistoryBackendTest, MergeFaviconIconURLMappedToDifferentPageURL) {

EXPECT_NE(0, favicon_id);

EXPECT_TRUE(GetOnlyFaviconBitmap(favicon_id, &favicon_bitmap));

- EXPECT_NE(base::Time(), favicon_bitmap.last_updated);

+ EXPECT_EQ(base::Time(), favicon_bitmap.last_updated);

EXPECT_TRUE(BitmapDataEqual('b', favicon_bitmap.bitmap_data));

EXPECT_EQ(kSmallSize, favicon_bitmap.pixel_size);