Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: fpdfsdk/include/fxedit/fx_edit.h

Issue 1098043002: Remove Release() from IFX_Edit_UndoItem. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Unused CFFL_Edit_UndoItem Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « fpdfsdk/include/formfiller/FFL_TextField.h ('k') | fpdfsdk/include/fxedit/fxet_edit.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef _FX_EDIT_H_ 7 #ifndef _FX_EDIT_H_
8 #define _FX_EDIT_H_ 8 #define _FX_EDIT_H_
9 9
10 #include "../../../core/include/fxcrt/fx_basic.h" 10 #include "../../../core/include/fxcrt/fx_basic.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 //get the current position. 157 //get the current position.
158 virtual const CPVT_WordPlace & GetAt() const = 0; 158 virtual const CPVT_WordPlace & GetAt() const = 0;
159 159
160 //get the edit which this iterator belongs to 160 //get the edit which this iterator belongs to
161 virtual IFX_Edit* GetEdit( ) const = 0; 161 virtual IFX_Edit* GetEdit( ) const = 0;
162 }; 162 };
163 163
164 class IFX_Edit_UndoItem 164 class IFX_Edit_UndoItem
165 { 165 {
166 public: 166 public:
167 » virtual void» » » » » » » Release( ) = 0; 167 » virtual ~IFX_Edit_UndoItem() { }
Lei Zhang 2015/04/20 19:31:37 Impl to .cpp file, but I suppose this is just a mo
168
168 virtual void Undo() = 0; 169 virtual void Undo() = 0;
169 virtual void Redo() = 0; 170 virtual void Redo() = 0;
170 virtual CFX_WideString GetUndoTitle() = 0; 171 virtual CFX_WideString GetUndoTitle() = 0;
171
172 protected:
173 ~IFX_Edit_UndoItem() { }
174 }; 172 };
175 173
176 class FXET_CLASS IFX_Edit 174 class FXET_CLASS IFX_Edit
177 { 175 {
178 public: 176 public:
179 static IFX_Edit* NewEdit( ); 177 static IFX_Edit* NewEdit( );
180 static void DelEdit( IFX_Edit* pEdit); 178 static void DelEdit( IFX_Edit* pEdit);
181 179
182 //set a IFX_Edit_FontMap pointer implemented by user. 180 //set a IFX_Edit_FontMap pointer implemented by user.
183 virtual void SetFontM ap(IFX_Edit_FontMap* pFontMap) = 0; 181 virtual void SetFontM ap(IFX_Edit_FontMap* pFontMap) = 0;
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 virtual void OnVK_END (FX_BOOL bShift,FX_BOOL bCtrl) = 0; 487 virtual void OnVK_END (FX_BOOL bShift,FX_BOOL bCtrl) = 0;
490 virtual void OnVK(FX_ INT32 nItemIndex,FX_BOOL bShift,FX_BOOL bCtrl) = 0; 488 virtual void OnVK(FX_ INT32 nItemIndex,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
491 virtual FX_BOOL OnChar(F X_WORD nChar,FX_BOOL bShift,FX_BOOL bCtrl) = 0; 489 virtual FX_BOOL OnChar(F X_WORD nChar,FX_BOOL bShift,FX_BOOL bCtrl) = 0;
492 490
493 protected: 491 protected:
494 ~IFX_List() { } 492 ~IFX_List() { }
495 }; 493 };
496 494
497 #endif 495 #endif
498 496
OLDNEW
« no previous file with comments | « fpdfsdk/include/formfiller/FFL_TextField.h ('k') | fpdfsdk/include/fxedit/fxet_edit.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698