Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2538)

Unified Diff: runtime/bin/socket_macos.cc

Issue 109803002: Profiler Take 2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/socket_macos.cc
diff --git a/runtime/bin/socket_macos.cc b/runtime/bin/socket_macos.cc
index f626dff6057f735a6d1efe4dd7cfdbc710093337..50525e437eed1675329960266e64c9eab6cf9b0c 100644
--- a/runtime/bin/socket_macos.cc
+++ b/runtime/bin/socket_macos.cc
@@ -18,6 +18,7 @@
#include "bin/fdutils.h"
#include "bin/file.h"
#include "bin/log.h"
+#include "bin/signal_blocker.h"
#include "bin/socket.h"
@@ -106,6 +107,8 @@ intptr_t Socket::Available(intptr_t fd) {
int Socket::Read(intptr_t fd, void* buffer, intptr_t num_bytes) {
ASSERT(fd >= 0);
+ // Block profile interrupts while making I/O call.
+ ThreadSignalBlocker tsb(SIGPROF);
ssize_t read_bytes = TEMP_FAILURE_RETRY(read(fd, buffer, num_bytes));
ASSERT(EAGAIN == EWOULDBLOCK);
if (read_bytes == -1 && errno == EWOULDBLOCK) {
@@ -121,6 +124,8 @@ int Socket::RecvFrom(intptr_t fd, void* buffer, intptr_t num_bytes,
RawAddr* addr) {
ASSERT(fd >= 0);
socklen_t addr_len = sizeof(addr->ss);
+ // Block profile interrupts while making I/O call.
+ ThreadSignalBlocker tsb(SIGPROF);
ssize_t read_bytes =
TEMP_FAILURE_RETRY(
recvfrom(fd, buffer, num_bytes, 0, &addr->addr, &addr_len));
@@ -135,6 +140,8 @@ int Socket::RecvFrom(intptr_t fd, void* buffer, intptr_t num_bytes,
int Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {
ASSERT(fd >= 0);
+ // Block profile interrupts while making I/O call.
+ ThreadSignalBlocker tsb(SIGPROF);
ssize_t written_bytes = TEMP_FAILURE_RETRY(write(fd, buffer, num_bytes));
ASSERT(EAGAIN == EWOULDBLOCK);
if (written_bytes == -1 && errno == EWOULDBLOCK) {
@@ -149,6 +156,8 @@ int Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {
int Socket::SendTo(intptr_t fd, const void* buffer, intptr_t num_bytes,
RawAddr addr) {
ASSERT(fd >= 0);
+ // Block profile interrupts while making I/O call.
+ ThreadSignalBlocker tsb(SIGPROF);
ssize_t written_bytes =
TEMP_FAILURE_RETRY(
sendto(fd, buffer, num_bytes, 0,

Powered by Google App Engine
This is Rietveld 408576698