Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: runtime/vm/thread_test.cc

Issue 109803002: Profiler Take 2 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/thread_test.cc
diff --git a/runtime/vm/thread_test.cc b/runtime/vm/thread_test.cc
index 1305a1c51b3c2ad0d6d606ed0b03fdb0712274a2..400a50ee3a8d63293043e990c07a8e92c6b3b060 100644
--- a/runtime/vm/thread_test.cc
+++ b/runtime/vm/thread_test.cc
@@ -5,7 +5,7 @@
#include "platform/assert.h"
#include "vm/isolate.h"
#include "vm/unit_test.h"
-#include "vm/signal_handler.h"
+#include "vm/thread_interrupter.h"
#include "vm/thread.h"
namespace dart {
@@ -35,7 +35,8 @@ UNIT_TEST_CASE(Mutex) {
UNIT_TEST_CASE(Monitor) {
// This unit test case needs a running isolate.
Isolate* isolate = Isolate::Init(NULL);
-
+ // Interrupts interfere with this test.
+ ThreadInterrupter::Unregister();
Monitor* monitor = new Monitor();
monitor->Enter();
monitor->Exit();
@@ -43,10 +44,6 @@ UNIT_TEST_CASE(Monitor) {
const int kNumAttempts = 5;
int attempts = 0;
while (attempts < kNumAttempts) {
- // This test verifies that a monitor returns after the specified timeout. If
- // a signal is delivered to this thread, the monitor may return early.
- // Block signal delivery in this scope.
- ScopedSignalBlocker ssb;
MonitorLocker ml(monitor);
int64_t start = OS::GetCurrentTimeMillis();
int64_t wait_time = 2017;

Powered by Google App Engine
This is Rietveld 408576698