Profiler Take 2

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/platform.h"
 #include "bin/process.h"
 #include "bin/socket.h"
 
 #include "include/dart_api.h"
-
+#include "include/dart_native_api.h"
 
 namespace dart {
 namespace bin {
 
 static const int kProcessIdNativeField = 0;
 
 int Process::global_exit_code_ = 0;
 dart::Mutex* Process::global_exit_code_mutex_ = new dart::Mutex();
 
 // Extract an array of C strings from a list of Dart strings.
@@ skipping 178 matching lines @@
   intptr_t signal = DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 2));
   bool success = Process::Kill(pid, signal);
   Dart_SetReturnValue(args, Dart_NewBoolean(success));
 }
 
 
 void FUNCTION_NAME(Process_Exit)(Dart_NativeArguments args) {
   int64_t status = 0;
   // Ignore result if passing invalid argument and just exit 0.
   DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status);
+  // On Windows we must shut down the thread interrupter before exiting,
+  // otherwise we may end up with a suspended thread and hung process.
+  Dart_ShutdownThreadInterrupter();

[siva, 2013/12/13 21:29:14]

Could we just call Dart_Cleanup() here, that would make things more consistent?

[Cutch, 2013/12/13 22:40:18]

Done.

   // Be sure to do platform-specific cleanups.
   Platform::Cleanup();
   exit(static_cast<int>(status));
 }
 
 
 void FUNCTION_NAME(Process_SetExitCode)(Dart_NativeArguments args) {
   int64_t status = 0;
   // Ignore result if passing invalid argument and just set exit code to 0.
   DartUtils::GetInt64Value(Dart_GetNativeArgument(args, 0), &status);
@@ skipping 60 matching lines @@
   int external_length = strlen(system_string);
   uint8_t* buffer = NULL;
   Dart_Handle external_array = IOBuffer::Allocate(external_length, &buffer);
   memmove(buffer, system_string, external_length);
   if (utf8 != system_string) free(const_cast<char*>(system_string));
   Dart_SetReturnValue(args, external_array);
 }
 
 }  // namespace bin
 }  // namespace dart