Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10980010: Cleanup the IPC param traits structure (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, tfarina, joi+watch-content_chromium.org, darin-cc_chromium.org, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Cleanup the IPC param traits structure: -traits that are only used by chrome should be in chrome -traits that aren't used by chrome shouldn't be in content/public -use macros for serialization where possible -traits that are only used by one message file should just be listed in it -get rid of webkit_param_traits since it's not needed anymore. It was added as a hack to keep npchrome_frame.dll's size small by giving a hint to the MSVS linker, but now that there's more split between the message files because of the content split it's not necessary anymore. I've verified that npchrome_frame.dll's size (Release, non-component) size doesn't change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158570

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : fix android #

Patch Set 4 : fix android #

Patch Set 5 : fix android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1169 lines, -1244 lines) Patch
M chrome/browser/component_updater/component_updater_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/importer/profile_import_process_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/autofill_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/automation_messages.h View 3 chunks +19 lines, -6 lines 0 comments Download
M chrome/common/automation_messages.cc View 5 chunks +175 lines, -28 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/autofill/form_autocomplete_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/page_click_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/async_resource_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/browser_plugin_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/cc_messages.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/common/cc_messages.cc View 1 chunk +139 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
A content/common/content_param_traits.h View 1 chunk +157 lines, -0 lines 0 comments Download
A content/common/content_param_traits.cc View 1 chunk +185 lines, -0 lines 0 comments Download
A content/common/content_param_traits_macros.h View 1 chunk +24 lines, -0 lines 0 comments Download
M content/common/fileapi/webblob_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/java_bridge_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_messages.h View 1 chunk +56 lines, -0 lines 0 comments Download
A content/common/resource_messages.cc View 1 chunk +293 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 4 chunks +2 lines, -13 lines 0 comments Download
M content/content_common.gypi View 4 chunks +6 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits.h View 5 chunks +0 lines, -70 lines 0 comments Download
M content/public/common/common_param_traits.cc View 4 chunks +0 lines, -357 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +51 lines, -4 lines 0 comments Download
D content/public/common/webkit_param_traits.h View 1 chunk +0 lines, -271 lines 0 comments Download
D content/public/common/webkit_param_traits.cc View 1 chunk +0 lines, -481 lines 0 comments Download
M content/renderer/java/java_bridge_dispatcher.h View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
8 years, 3 months ago (2012-09-25 03:33:49 UTC) #1
jam
(this is inspired by the issues with the current structure of the files that were ...
8 years, 3 months ago (2012-09-25 03:38:39 UTC) #2
piman
8 years, 3 months ago (2012-09-25 03:46:07 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698