Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3621)

Unified Diff: chrome/browser/ui/intents/web_intent_picker_controller.h

Issue 10980002: Mac Web Intents Part 1: Show extension download progress (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove downloads code Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/intents/web_intent_picker_controller.h
diff --git a/chrome/browser/ui/intents/web_intent_picker_controller.h b/chrome/browser/ui/intents/web_intent_picker_controller.h
index ffee1bcda60f04d0be944d98b2d64d0721dc2584..1a5412dbe79cab5e453fd8a366c39afdba0e09cd 100644
--- a/chrome/browser/ui/intents/web_intent_picker_controller.h
+++ b/chrome/browser/ui/intents/web_intent_picker_controller.h
@@ -114,9 +114,16 @@ class WebIntentPickerController
virtual void OnClosing() OVERRIDE;
// extensions::WebstoreInstaller::Delegate implementation.
+ virtual void OnExtensionDownloadStarted(const std::string& id,
+ content::DownloadItem* item) OVERRIDE;
+ virtual void OnExtensionDownloadProgress(
+ const std::string& id,
+ content::DownloadItem* item) OVERRIDE;
virtual void OnExtensionInstallSuccess(const std::string& id) OVERRIDE;
- virtual void OnExtensionInstallFailure(const std::string& id,
- const std::string& error) OVERRIDE;
+ virtual void OnExtensionInstallFailure(
+ const std::string& id,
+ const std::string& error,
+ extensions::WebstoreInstaller::FailureReason reason) OVERRIDE;
private:
explicit WebIntentPickerController(content::WebContents* web_contents);
@@ -249,6 +256,9 @@ class WebIntentPickerController
// loading the picker model and showing the dialog.
void ShowDialog(bool suppress_defaults);
+ // Cancel a pending download if any.
+ void CancelDownload();
+
WebIntentPickerState dialog_state_; // Current state of the dialog.
// A weak pointer to the web contents that the picker is displayed on.
@@ -332,6 +342,9 @@ class WebIntentPickerController
// |intents_dispatcher_| is set.
web_intents::UMABucket uma_bucket_;
+ // The ID of a pending extension download.
+ content::DownloadId download_id_;
+
DISALLOW_COPY_AND_ASSIGN(WebIntentPickerController);
};
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | chrome/browser/ui/intents/web_intent_picker_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698