Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1642)

Issue 1097963003: Fix reporting of shard number in buildbot (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 4 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Fix reporting of shard number in buildbot We are mixing zero-based (SHARD) and one-based (SHARDS) number in way that is a little confusing. This change at converts SHARD to one-based when reporting the shard number. R=bradnelson@google.com Committed: https://chromium.googlesource.com/external/naclports/+/0a29d8ba01242ff9fa6829526a357970b3871cd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_tools/buildbot_build_shard.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
5 years, 5 months ago (2015-07-16 15:22:06 UTC) #2
bradn
lgtm
5 years, 5 months ago (2015-07-16 15:51:04 UTC) #4
Sam Clegg
5 years, 4 months ago (2015-08-18 15:47:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a29d8ba01242ff9fa6829526a357970b3871cd4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698