Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1097933002: Rid ourselves of unnecessary expected files (Closed)

Created:
5 years, 8 months ago by davve
Modified:
5 years, 8 months ago
Reviewers:
philipj_slow
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rid ourselves of unnecessary expected files Get rid of -expected.txt files from SVG baseline files by removing text from the DOM. Having text elements linger classifies the tests as 'text' and requires them to have expected files. By cleaning up the text elements before test ends, we can get rid of the expected files. BUG=476344 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M LayoutTests/svg/custom/zoomed-alignment-baseline.html View 1 chunk +2 lines, -1 line 0 comments Download
D LayoutTests/svg/custom/zoomed-alignment-baseline-expected.txt View 1 chunk +0 lines, -27 lines 0 comments Download
M LayoutTests/svg/custom/zoomed-baseline-shift.html View 1 chunk +2 lines, -1 line 0 comments Download
D LayoutTests/svg/custom/zoomed-baseline-shift-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
davve
5 years, 8 months ago (2015-04-20 13:12:59 UTC) #2
philipj_slow
lgtm
5 years, 8 months ago (2015-04-20 13:17:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097933002/1
5 years, 8 months ago (2015-04-20 14:11:24 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 14:38:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194030

Powered by Google App Engine
This is Rietveld 408576698