chrome/browser/extensions/api/image_writer_private/operation_linux.cc - Issue 109793006: Adds ImageWriterPrivate.destroyPartitions operation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/operation_linux.cc

Issue 109793006: Adds ImageWriterPrivate.destroyPartitions operation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc ('K') | « chrome/browser/extensions/api/image_writer_private/operation.cc ('k') | chrome/browser/extensions/api/image_writer_private/operation_manager.h » ('j') | chrome/browser/extensions/api/image_writer_private/operation_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/operation_linux.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/operation_linux.cc b/chrome/browser/extensions/api/image_writer_private/operation_linux.cc

index e54b5241ceba913bc194311d659830c42471d5fc..4b92badca9fb8e6658106efe265aaf6a037a2a69 100644

--- a/chrome/browser/extensions/api/image_writer_private/operation_linux.cc

+++ b/chrome/browser/extensions/api/image_writer_private/operation_linux.cc

@@ -138,11 +138,19 @@ void Operation::WriteComplete() {

DVLOG(2) << "Completed write of " << image_path_.value();

SetProgress(kProgressComplete);

- BrowserThread::PostTask(

- BrowserThread::FILE,

- FROM_HERE,

- base::Bind(&Operation::VerifyWriteStart,

- this));

+ if (verify_write_) {

+ BrowserThread::PostTask(

+ BrowserThread::FILE,

tbarzic 2013/12/14 01:01:04 indent+=2

Drew Haven 2013/12/16 20:15:33 Done.

+ FROM_HERE,

+ base::Bind(&Operation::VerifyWriteStart,

+ this));

tbarzic 2013/12/14 01:01:04 can't this fit in the previous line?

Drew Haven 2013/12/16 20:15:33 Yep, oops. Hold-over from a longer set of argumen

+ } else {

+ BrowserThread::PostTask(

+ BrowserThread::FILE,

+ FROM_HERE,

+ base::Bind(&Operation::Finish,

+ this));

+ }

}

void Operation::VerifyWriteStart() {