Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc

Issue 1097913002: Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
diff --git a/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc b/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
index cff95f385a9ce7cf2d646c45ff8d1c5b2ee63b03..a2d40b2cc538de31751d671943821c6b507f7bcf 100644
--- a/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
+++ b/content/common/gpu/media/v4l2_slice_video_decode_accelerator.cc
@@ -576,8 +576,9 @@ bool V4L2SliceVideoDecodeAccelerator::SetupFormats() {
}
size_t input_size;
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kIgnoreResolutionLimitsForAcceleratedVideoDecode))
+ gfx::Size max_resolution = device_->GetMaxSupportedResolution(
+ input_format_fourcc);
+ if (max_resolution.width() >= 1920 && max_resolution.height() >= 1080)
wuchengli 2015/04/23 07:11:44 This should be >, not >=. s/1080/1088/ because th
henryhsu 2015/04/23 08:21:54 Done.
input_size = kInputBufferMaxSizeFor4k;
else
input_size = kInputBufferMaxSizeFor1080p;
@@ -2506,37 +2507,8 @@ V4L2SliceVideoDecodeAccelerator::GetSupportedProfiles() {
if (!device)
return profiles;
wuchengli 2015/04/23 07:11:44 return SupportedProfiles(). remove |profiles|
henryhsu 2015/04/23 08:21:54 Done.
- SupportedProfile profile;
- profile.min_resolution.SetSize(16, 16);
- // NOTE: additional autodetection logic may require updating input buffer size
- // selection.
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kIgnoreResolutionLimitsForAcceleratedVideoDecode))
- profile.max_resolution.SetSize(4096, 2160);
- else
- profile.max_resolution.SetSize(1920, 1088);
-
- v4l2_fmtdesc fmtdesc;
- memset(&fmtdesc, 0, sizeof(fmtdesc));
- fmtdesc.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
- for (; device->Ioctl(VIDIOC_ENUM_FMT, &fmtdesc) == 0; ++fmtdesc.index) {
- switch (fmtdesc.pixelformat) {
- case V4L2_PIX_FMT_H264_SLICE:
- for (uint32 media_profile = media::H264PROFILE_MIN;
- media_profile <= media::H264PROFILE_MAX; ++media_profile) {
- profile.profile =
- static_cast<media::VideoCodecProfile>(media_profile);
- profiles.push_back(profile);
- }
- break;
- case V4L2_PIX_FMT_VP8_FRAME:
- profile.profile = media::VP8PROFILE_ANY;
- profiles.push_back(profile);
- break;
- }
- }
-
- return profiles;
+ return device->GetSupportedDecodeProfiles(std::vector<uint32_t>(
+ {V4L2_PIX_FMT_H264_SLICE, V4L2_PIX_FMT_VP8_FRAME}));
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698