content/common/gpu/media/v4l2_device.h - Issue 1097913002: Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_device.h

Issue 1097913002: Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/chrome_restart_request.cc ('K') | « content/browser/renderer_host/render_process_host_impl.cc ('k') | content/common/gpu/media/v4l2_device.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/v4l2_device.h

diff --git a/content/common/gpu/media/v4l2_device.h b/content/common/gpu/media/v4l2_device.h

index 72af69967b3ea83d9820eee283b52e88b6754cad..c47cc565041bd35a2261027c2bcb27e9c5f2ee74 100644

--- a/content/common/gpu/media/v4l2_device.h

+++ b/content/common/gpu/media/v4l2_device.h

@@ -34,6 +34,9 @@ class CONTENT_EXPORT V4L2Device

static uint32_t V4L2PixFmtToDrmFormat(uint32_t format);

// Convert format requirements requested by a V4L2 device to gfx::Size.

static gfx::Size CodedSizeFromV4L2Format(struct v4l2_format format);

+ // Get maximum resolution for fourcc format.

+ static gfx::Size GetMaxSupportedResolution(

wuchengli 2015/04/21 08:46:41 This should be a member function, not static. But

+ const scoped_refptr<V4L2Device>& device, unsigned int pixelformat);

enum Type {

kDecoder,