content/common/gpu/media/v4l2_video_encode_accelerator.cc - Issue 1097913002: Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/v4l2_video_encode_accelerator.cc

Issue 1097913002: Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Pawel's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/media/v4l2_video_encode_accelerator.cc

diff --git a/content/common/gpu/media/v4l2_video_encode_accelerator.cc b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

index d07574008eddcfc7f83501f1b85cd8b902bd8a57..4ae0b731fbd2c72fd70ce9ce2290f21ab541df57 100644

--- a/content/common/gpu/media/v4l2_video_encode_accelerator.cc

+++ b/content/common/gpu/media/v4l2_video_encode_accelerator.cc

@@ -289,14 +289,16 @@ media::VideoEncodeAccelerator::SupportedProfiles

V4L2VideoEncodeAccelerator::GetSupportedProfiles() {

SupportedProfiles profiles;

SupportedProfile profile;

- profile.max_resolution.SetSize(1920, 1088);

profile.max_framerate_numerator = 30;

profile.max_framerate_denominator = 1;

+ gfx::Size min_resolution;

Pawel Osciak 2015/04/28 01:35:33 We should add this to VEA::SupportedProfile for co

henryhsu 2015/04/28 05:06:56 Hmm..Let us do it in next CL.

v4l2_fmtdesc fmtdesc;

memset(&fmtdesc, 0, sizeof(fmtdesc));

fmtdesc.type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE;

for (; device_->Ioctl(VIDIOC_ENUM_FMT, &fmtdesc) == 0; ++fmtdesc.index) {

+ device_->GetSupportedResolution(fmtdesc.pixelformat,

+ &profile.max_resolution, &min_resolution);

switch (fmtdesc.pixelformat) {

case V4L2_PIX_FMT_H264:

profile.profile = media::H264PROFILE_MAIN;

« content/common/gpu/media/v4l2_device.cc ('K') | « content/common/gpu/media/v4l2_video_decode_accelerator.cc ('k') | media/base/media_switches.h » ('j') | no next file with comments »