Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag

content/common/gpu/media/v4l2_video_decode_accelerator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <dlfcn.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/videodev2.h>
 #include <poll.h>
 #include <sys/eventfd.h>
@@ skipping 432 matching lines @@
 }
 
 bool V4L2VideoDecodeAccelerator::CanDecodeOnIOThread() { return true; }
 
 // static
 media::VideoDecodeAccelerator::SupportedProfiles
 V4L2VideoDecodeAccelerator::GetSupportedProfiles() {
   SupportedProfiles profiles;
   scoped_refptr<V4L2Device> device = V4L2Device::Create(V4L2Device::kDecoder);
   if (!device)
     return profiles;

[wuchengli, 2015/04/23 07:11:44]

return SupportedProfiles(). remove |profiles|

[henryhsu, 2015/04/23 08:21:54]

Done.

 
-  SupportedProfile profile;
-  profile.min_resolution.SetSize(16, 16);
-  // NOTE: additional autodetection logic may require updating input buffer size
-  // selection.
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kIgnoreResolutionLimitsForAcceleratedVideoDecode))
-    profile.max_resolution.SetSize(4096, 2160);
-  else
-    profile.max_resolution.SetSize(1920, 1088);
-
-  v4l2_fmtdesc fmtdesc;
-  memset(&fmtdesc, 0, sizeof(fmtdesc));
-  fmtdesc.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
-  for (; device->Ioctl(VIDIOC_ENUM_FMT, &fmtdesc) == 0; ++fmtdesc.index) {
-    switch (fmtdesc.pixelformat) {
-      case V4L2_PIX_FMT_H264:
-        for (uint32 media_profile = media::H264PROFILE_MIN;
-            media_profile <= media::H264PROFILE_MAX; ++media_profile) {
-          profile.profile =
-              static_cast<media::VideoCodecProfile>(media_profile);
-          profiles.push_back(profile);
-        }
-        break;
-      case V4L2_PIX_FMT_VP8:
-        profile.profile = media::VP8PROFILE_ANY;
-        profiles.push_back(profile);
-        break;
-      case V4L2_PIX_FMT_VP9:
-        profile.profile = media::VP9PROFILE_ANY;
-        profiles.push_back(profile);
-        break;
-    }
-  }
-
-  return profiles;
+  return device->GetSupportedDecodeProfiles(std::vector<uint32_t>(
+      {V4L2_PIX_FMT_H264, V4L2_PIX_FMT_VP8, V4L2_PIX_FMT_VP9}));
 }
 
 void V4L2VideoDecodeAccelerator::DecodeTask(
     const media::BitstreamBuffer& bitstream_buffer) {
   DVLOG(3) << "DecodeTask(): input_id=" << bitstream_buffer.id();
   DCHECK_EQ(decoder_thread_.message_loop(), base::MessageLoop::current());
   DCHECK_NE(decoder_state_, kUninitialized);
   TRACE_EVENT1("Video Decoder", "V4L2VDA::DecodeTask", "input_id",
                bitstream_buffer.id());
 
@@ skipping 1292 matching lines @@
   DCHECK(!output_streamon_);
 
   __u32 input_format_fourcc =
       V4L2Device::VideoCodecProfileToV4L2PixFmt(video_profile_, false);
   if (!input_format_fourcc) {
     NOTREACHED();
     return false;
   }
 
   size_t input_size;
-  if (base::CommandLine::ForCurrentProcess()->HasSwitch(
-          switches::kIgnoreResolutionLimitsForAcceleratedVideoDecode))
+  gfx::Size max_resolution =
+      device_->GetMaxSupportedResolution(input_format_fourcc);
+  if (max_resolution.width() >= 1920 && max_resolution.height() >= 1080)

[wuchengli, 2015/04/23 07:11:44]

s/>=/>/

[henryhsu, 2015/04/23 08:21:54]

Done.

     input_size = kInputBufferMaxSizeFor4k;
   else
     input_size = kInputBufferMaxSizeFor1080p;
 
   struct v4l2_format format;
   memset(&format, 0, sizeof(format));
   format.type = V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE;
   format.fmt.pix_mp.pixelformat = input_format_fourcc;
   format.fmt.pix_mp.plane_fmt[0].sizeimage = input_size;
   format.fmt.pix_mp.num_planes = 1;
@@ skipping 243 matching lines @@
   gfx::Size new_coded_size(base::checked_cast<int>(format.fmt.pix_mp.width),
                            base::checked_cast<int>(format.fmt.pix_mp.height));
   if (coded_size_ != new_coded_size) {
     DVLOG(3) << "IsResolutionChangeNecessary(): Resolution change detected";
     return true;
   }
   return false;
 }
 
 }  // namespace content