Remove kIgnoreResolutionLimitsForAcceleratedVideoDecode flag

content/common/gpu/media/v4l2_device.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <libdrm/drm_fourcc.h>
 #include <linux/videodev2.h>
 
 #include "base/numerics/safe_conversions.h"
 #include "content/common/gpu/media/generic_v4l2_device.h"
 #if defined(ARCH_CPU_ARMEL)
@@ skipping 179 matching lines @@
 
   // Sanity checks. Calculated coded size has to contain given visible size
   // and fulfill buffer byte size requirements.
   DCHECK(gfx::Rect(coded_size).Contains(gfx::Rect(visible_size)));
   DCHECK_LE(sizeimage,
             media::VideoFrame::AllocationSize(frame_format, coded_size));
 
   return coded_size;
 }
 
+// static
+gfx::Size V4L2Device::GetSupportedMaxResolution(

[wuchengli, 2015/04/20 14:05:16]

s/GetSupportedMaxResolution/GetMaxSupportedResolution/

[henryhsu, 2015/04/21 05:56:27]

Done.

+    const scoped_refptr<V4L2Device>& device,
+    unsigned int format) {

[wuchengli, 2015/04/20 14:05:16]

s/format/pixelformat/

[henryhsu, 2015/04/21 05:56:27]

Done.

+  gfx::Size max_resolution;
+  v4l2_frmsizeenum fsize;

[wuchengli, 2015/04/20 14:05:16]

s/fsize/frame_size/ is more descriptive

[henryhsu, 2015/04/21 05:56:27]

Done.

+  memset(&fsize, 0, sizeof(fsize));
+  fsize.pixel_format = format;
+  int ret;

[wuchengli, 2015/04/20 14:05:16]

not needed

[henryhsu, 2015/04/21 05:56:27]

Done.

+  for (; (ret = device->Ioctl(VIDIOC_ENUM_FRAMESIZES, &fsize)) == 0;
+       ++fsize.index) {
+    if (fsize.type == V4L2_FRMIVAL_TYPE_DISCRETE) {
+      if (fsize.discrete.width >
+              static_cast<unsigned int>(max_resolution.width()) &&
+          fsize.discrete.height >
+              static_cast<unsigned int>(max_resolution.height())) {
+        max_resolution.SetSize(fsize.discrete.width, fsize.discrete.height);
+      }
+    } else if (fsize.type == V4L2_FRMIVAL_TYPE_STEPWISE) {
+      max_resolution.SetSize(fsize.stepwise.max_width,

[wuchengli, 2015/04/20 14:05:16]

Why don't we need to check if this is the maximum like line 212-216? There will
be only one frame size?

[henryhsu, 2015/04/21 05:56:27]

Because discrete type has many results. We need to query and increase index to
get different supported resolutions until query return failure.
But stepwise type just returns a region including minimum and maximum width and
height. So we can use maximum width and height directly.

+                             fsize.stepwise.max_height);
+    }

[wuchengli, 2015/04/20 14:05:16]

No need to consider V4L2_FRMIVAL_TYPE_CONTINUOUS?

[henryhsu, 2015/04/21 05:56:27]

Done.

+  }
+  return max_resolution;
+}
+
 }  //  namespace content