Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: runtime/vm/flow_graph.cc

Issue 10979073: Disable slow debug assertions in use-list verification code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.cc
diff --git a/runtime/vm/flow_graph.cc b/runtime/vm/flow_graph.cc
index 5d0984185bf3fc24b388350ac5987d293501f115..be7d71e828a98a9a51ab70baca0380bc1c4853f7 100644
--- a/runtime/vm/flow_graph.cc
+++ b/runtime/vm/flow_graph.cc
@@ -135,14 +135,16 @@ static void ValidateUseListsInInstruction(Instruction* instr) {
for (intptr_t i = 0; i < instr->InputCount(); ++i) {
Value* use = instr->InputAt(i);
ASSERT(use->use_index() == i);
- ASSERT(1 == MembershipCount(use, use->definition()->input_use_list()));
+ // TODO(zerny): Make this a slow assert.
+ // ASSERT(1 == MembershipCount(use, use->definition()->input_use_list()));
}
if (instr->env() != NULL) {
intptr_t use_index = 0;
for (Environment::DeepIterator it(instr->env()); !it.Done(); it.Advance()) {
Value* use = it.CurrentValue();
ASSERT(use->use_index() == use_index++);
- ASSERT(1 == MembershipCount(use, use->definition()->env_use_list()));
+ // TODO(zerny): Make this a slow assert.
+ // ASSERT(1 == MembershipCount(use, use->definition()->env_use_list()));
}
}
Definition* defn = instr->AsDefinition();
@@ -205,8 +207,9 @@ static void RecordInputUses(Instruction* instr) {
ASSERT(use->instruction() == NULL);
ASSERT(use->use_index() == -1);
ASSERT(use->next_use() == NULL);
- DEBUG_ASSERT(0 == MembershipCount(use,
- use->definition()->input_use_list()));
+ // TODO(zerny): Make this a slow assert.
+ // DEBUG_ASSERT(0 == MembershipCount(use,
+ // use->definition()->input_use_list()));
use->set_instruction(instr);
use->set_use_index(i);
use->AddToInputUseList();
@@ -223,7 +226,9 @@ static void RecordEnvUses(Instruction* instr) {
ASSERT(use->instruction() == NULL);
ASSERT(use->use_index() == -1);
ASSERT(use->next_use() == NULL);
- DEBUG_ASSERT(0 == MembershipCount(use, use->definition()->env_use_list()));
+ // TODO(zerny): Make this a slow assert.
+ // DEBUG_ASSERT(0 ==
+ // MembershipCount(use, use->definition()->env_use_list()));
use->set_instruction(instr);
use->set_use_index(use_index++);
use->AddToEnvUseList();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698