Issue 10979061: Track correctly the number of secure command channel connections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979061: Track correctly the number of secure command channel connections (Closed)

Created:
8 years, 2 months ago by Petr Hosek

Modified:
8 years, 2 months ago

Reviewers:
bsy, Derek Schuff, (google.com) Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Track correctly the number of secure command channel connections Currently, we track number of secure command channel threads. However, these are not directly related to the number of command channels which might result in sel_ldr hanging around even after last connection went away. Note that r9853 broke Chromium integration, causing run_pnacl_bad_browser_test to fail in the PNaCl tests (on the *_naclmore bots only). This change should fix that. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3051 TESTS=small_tests Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9882

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -129 lines)			Patch
M	SConstruct	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/trusted/sel_universal/reverse_emulate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/trusted/sel_universal/reverse_emulate.cc	View	1	6 chunks	+40 lines, -0 lines	0 comments	Download
M	src/trusted/sel_universal/rpc_universal.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/trusted/sel_universal/sel_universal.cc	View		2 chunks	+22 lines, -0 lines	0 comments	Download
M	src/trusted/service_runtime/nacl_secure_service.h	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/trusted/service_runtime/nacl_secure_service.c	View	1 2	6 chunks	+32 lines, -127 lines	0 comments	Download
A	tests/sel_ldr/force_shutdown_test.stdin	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/sel_ldr/hard_shutdown_test.stdin	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/sel_ldr/nacl.scons	View		1 chunk	+33 lines, -0 lines	0 comments	Download
A +	tests/sel_ldr/non_exit.c	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 2 months ago (2012-09-29 00:38:32 UTC) #4

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/phosek@chromium.org/10979061/3008

Expand Messages | Collapse Messages

Issue 10979061: Track correctly the number of secure command channel connections (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebased with master. #

Patch Set 3 : Properly initialize instance variables. #

Patch Set 4 : Rebased with master. #

Messages