Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: runtime/lib/object_patch.dart

Issue 10979050: Ensure that hashCode and runtimeType work on null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch class Object { 5 patch class Object {
6 6
7 // Helpers used to implement hashCode. If a hashCode is used we remember it 7 // Helpers used to implement hashCode. If a hashCode is used we remember it
8 // using an Expando object. A new hashCode value is calculated using a Random 8 // using an Expando object. A new hashCode value is calculated using a Random
9 // number generator. 9 // number generator.
10 static Expando _hashCodeExp = new Expando("Object.hashCode"); 10 static Expando _hashCodeExp = new Expando("Object.hashCode");
11 static Random _hashCodeRnd = new Random(); 11 static Random _hashCodeRnd = new Random();
12 12
13 /* patch */ int hashCode() { 13 /* patch */ int hashCode() {
14 var result = _hashCodeExp[this]; 14 var result = _hashCodeExp[this];
15 if (result == null) { 15 if (result == null) {
16 result = _hashCodeRnd.nextInt(0x40000000); // Stay in Smi range. 16 result = _hashCodeRnd.nextInt(0x40000000); // Stay in Smi range.
17 _hashCodeExp[this] = result; 17 _hashCodeExp[this] = result;
18 } 18 }
19 return result; 19 return result;
20 } 20 }
21 21
22 /* patch */ String toString() => _toString(this); 22 /* patch */ String toString() => _toString(this);
23 23
24 /* patch */ Dynamic noSuchMethod(String functionName, List args) { 24 /* patch */ Dynamic noSuchMethod(String functionName, List args) {
25 _noSuchMethod(this, functionName, args); 25 _noSuchMethod(this, functionName, args);
26 } 26 }
27 27
28 // Not yet supported.
29 /* patch */ Type get runtimeType => null;
ahe 2012/09/27 11:30:54 Perhaps you should throw an exception instead.
30
28 static void _noSuchMethod(Object obj, String functionName, List args) 31 static void _noSuchMethod(Object obj, String functionName, List args)
29 native "Object_noSuchMethod"; 32 native "Object_noSuchMethod";
30 33
31 static String _toString(Object obj) native "Object_toString"; 34 static String _toString(Object obj) native "Object_toString";
32 } 35 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698