Issue 10979026: Merge 129296 - HTMLMediaElement isn't garbage collected between document reloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979026: Merge 129296 - HTMLMediaElement isn't garbage collected between document reloads (Closed)

Created:
8 years, 2 months ago by Ami GONE FROM CHROMIUM

Modified:
8 years, 2 months ago

Reviewers:
Ami GONE FROM CHROMIUM

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Visibility:
Public.

More Reviews

Description

Merge 129296 - HTMLMediaElement isn't garbage collected between document reloads https://bugs.webkit.org/show_bug.cgi?id=97020 Reviewed by Eric Carlson. .: Manual test added: ManualTests/audio-freed-during-reload.html * ManualTests/audio-freed-during-reload.html: Source/WebCore: JS-created (as opposed to DOM-created) Audio nodes never got collected, because they appear to always hasPendingActivity(), because m_playing is never set to false. Manual test added: ManualTests/audio-freed-during-reload.html * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::stop): set m_playing = false; explicitly. TBR=fischman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=129562

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, --1 lines)			Patch
	A +	ManualTests/audio-freed-during-reload.html	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	M	Source/WebCore/html/HTMLMediaElement.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages