Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1041)

Issue 10979024: Add OWNERS file for build/android/buildbot (Closed)

Created:
8 years, 2 months ago by Isaac (away)
Modified:
8 years, 2 months ago
Reviewers:
cmp, Dirk Pranke, Yaron
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add OWNERS file for build/android/buildbot - Owners based on number of commits and numbers of reviews of code in this directory. R=yaron,cmp BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A + build/android/buildbot/OWNERS View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Isaac (away)
8 years, 2 months ago (2012-09-25 21:58:32 UTC) #1
Yaron
lgtm
8 years, 2 months ago (2012-09-25 22:47:03 UTC) #2
cmp
lgtm +dpranke for review since he added the OWNERS file in src/build/
8 years, 2 months ago (2012-09-25 23:02:28 UTC) #3
Dirk Pranke
why the 'set noparent'? I thought we wanted to move away from using that.
8 years, 2 months ago (2012-09-25 23:35:00 UTC) #4
Isaac (away)
because build/ directory is * but this directory manages our buildbots, incl ones on the ...
8 years, 2 months ago (2012-09-25 23:51:04 UTC) #5
Dirk Pranke
There is no "*" in build/OWNERS that I see ... are you worried that there ...
8 years, 2 months ago (2012-09-25 23:58:48 UTC) #6
cmp
On 2012/09/25 23:58:48, Dirk Pranke wrote: > There is no "*" in build/OWNERS that I ...
8 years, 2 months ago (2012-09-26 00:04:23 UTC) #7
Dirk Pranke
8 years, 2 months ago (2012-09-26 00:10:30 UTC) #8
On Tue, Sep 25, 2012 at 5:04 PM,  <cmp@chromium.org> wrote:
> On 2012/09/25 23:58:48, Dirk Pranke wrote:
>>
>> There is no "*" in build/OWNERS that I see
>
>
> Can you confirm that?  Before I lgtm'd I checked src/build/OWNERS and saw
> that
> it had * as its only content:
>
http://src.chromium.org/viewvc/chrome/trunk/src/build/OWNERS?revision=126218&...
>

I'm sorry, my mistake. I was looking in tools/build, not src/build.
Your use of the "*" is fine, then :).

lgtm.

Powered by Google App Engine
This is Rietveld 408576698