Issue 10979022: Add new files for panel test extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10979022: Add new files for panel test extension. (Closed)

Created:
8 years, 2 months ago by jianli

Modified:
8 years, 2 months ago

Reviewers:
jennb

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add new files for panel test extension. This is submitted in a separate patch since it contains some binary files. BUG=none TEST=These are test data files. TBR=jennb Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158899

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix per feedback #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -6 lines)			Patch
A +	chrome/test/data/panels/test_extension/128.png	View		Binary file		0 comments	Download
A +	chrome/test/data/panels/test_extension/24.png	View		Binary file		0 comments	Download
A +	chrome/test/data/panels/test_extension/32.png	View		Binary file		0 comments	Download
A +	chrome/test/data/panels/test_extension/hello.html	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A	chrome/test/data/panels/test_extension/manifest.json	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	chrome/test/data/panels/test_extension/test.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jennb

http://codereview.chromium.org/10979022/diff/1/chrome/test/data/panels/test_extension/manifest.json File chrome/test/data/panels/test_extension/manifest.json (right): http://codereview.chromium.org/10979022/diff/1/chrome/test/data/panels/test_extension/manifest.json#newcode5 chrome/test/data/panels/test_extension/manifest.json:5: "description": "Tests extension.", It is helpful to be more ...

8 years, 2 months ago (2012-09-25 22:05:07 UTC) #2

jianli

8 years, 2 months ago (2012-09-25 22:19:18 UTC) #3

http://codereview.chromium.org/10979022/diff/1/chrome/test/data/panels/test_e...
File chrome/test/data/panels/test_extension/manifest.json (right):

http://codereview.chromium.org/10979022/diff/1/chrome/test/data/panels/test_e...
chrome/test/data/panels/test_extension/manifest.json:5: "description": "Tests
extension.",
On 2012/09/25 22:05:08, jennb wrote:
> It is helpful to be more descriptive here and say what this extension is
> designed to test.

Done.

Expand Messages | Collapse Messages