Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10979009: Move content test utils to content/public/test (Closed)

Created:
8 years, 3 months ago by nyquist
Modified:
8 years, 2 months ago
Reviewers:
cjhopman, joth, Yaron, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Move content test utils to content/public/test We have several test utils in content/public/android/javatests/src/org/chromium/content/browser/util that needs to be part of its own gyp target. This creates the target and moves the test utils to that target. TBR=jam@chromium.org, joth@chromium.org BUG=151561, 150617 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158599

Patch Set 1 #

Patch Set 2 : Fixed content_java_test_support package name #

Patch Set 3 : Added OWNERS file #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased on new branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -621 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AndroidWebViewTestBase.java View 1 chunk +2 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 1 chunk +3 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java View 1 chunk +4 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +15 lines, -0 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/CallbackHelper.java View 1 chunk +0 lines, -95 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/Criteria.java View 1 chunk +0 lines, -17 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/CriteriaHelper.java View 1 chunk +0 lines, -71 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/HistoryUtils.java View 1 chunk +0 lines, -191 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/TestCallbackHelperContainer.java View 1 chunk +0 lines, -104 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/TestContentViewClient.java View 1 chunk +0 lines, -43 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/util/TestWebContentsObserver.java View 1 chunk +0 lines, -66 lines 0 comments Download
A + content/public/test/android/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/Criteria.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CriteriaHelper.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java View 1 chunk +1 line, -1 line 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestContentViewClient.java View 1 chunk +2 lines, -5 lines 0 comments Download
A + content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestWebContentsObserver.java View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
nyquist
PTAL
8 years, 3 months ago (2012-09-25 00:14:51 UTC) #1
Yaron
lgtm
8 years, 3 months ago (2012-09-25 00:21:22 UTC) #2
Yaron
On 2012/09/25 00:21:22, Yaron wrote: > lgtm Please add OWNERS file that matches content/public/android/OWNERS
8 years, 3 months ago (2012-09-25 00:21:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/10979009/5001
8 years, 3 months ago (2012-09-25 00:28:45 UTC) #4
commit-bot: I haz the power
Presubmit check for 10979009-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-25 00:28:51 UTC) #5
jam
gypi lgtm
8 years, 2 months ago (2012-09-25 16:18:47 UTC) #6
nyquist
8 years, 2 months ago (2012-09-25 16:57:38 UTC) #7
On 2012/09/25 16:18:47, John Abd-El-Malek wrote:
> gypi lgtm

We should update the tools accept lines longer than 100 characters for imports.
For reference, see:
http://source.android.com/source/code-style.html#limit-line-length

Powered by Google App Engine
This is Rietveld 408576698