Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097893003: Oilpan: fix build after r194009. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 8 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, rwlbuis, fs, kouhei+svg_chromium.org, dstockwell, Timothy Loh, krit, f(malita), darktears, gyuyoung2, Stephen Chennney, Steve Block, pdr+svgwatchlist_chromium.org, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r194009. Arrange for SVGPropertyTearOff.h to be able to #include SVGElement.h, so as to avoid any SVGElement visibility breakages downstream. R=haraken,kouhei BUG=477527 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/core/animation/IntegerOptionalIntegerSVGInterpolation.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGElement.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/SVGStringList.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/properties/SVGPropertyTearOff.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. The CL just happened to step onto a latent problem (SVGElement's ...
5 years, 8 months ago (2015-04-20 12:04:13 UTC) #1
haraken
LGTM
5 years, 8 months ago (2015-04-20 12:05:39 UTC) #2
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-20 12:07:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097893003/1
5 years, 8 months ago (2015-04-20 12:15:01 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 12:18:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194023

Powered by Google App Engine
This is Rietveld 408576698