Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/resources/bookmark_manager/js/main.js

Issue 1097873002: Copy and Cut option of the context menu is not working via keyboard in chrome://bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 /** @const */ var BookmarkList = bmm.BookmarkList; 6 /** @const */ var BookmarkList = bmm.BookmarkList;
7 /** @const */ var BookmarkTree = bmm.BookmarkTree; 7 /** @const */ var BookmarkTree = bmm.BookmarkTree;
8 /** @const */ var Command = cr.ui.Command; 8 /** @const */ var Command = cr.ui.Command;
9 /** @const */ var LinkKind = cr.LinkKind; 9 /** @const */ var LinkKind = cr.LinkKind;
10 /** @const */ var ListItem = cr.ui.ListItem; 10 /** @const */ var ListItem = cr.ui.ListItem;
(...skipping 1241 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 return filteredIds; 1252 return filteredIds;
1253 } 1253 }
1254 1254
1255 /** 1255 /**
1256 * Handler for the command event. This is used for context menu of list/tree 1256 * Handler for the command event. This is used for context menu of list/tree
1257 * and organized menu. 1257 * and organized menu.
1258 * @param {!Event} e The event object. 1258 * @param {!Event} e The event object.
1259 */ 1259 */
1260 function handleCommand(e) { 1260 function handleCommand(e) {
1261 var command = e.command; 1261 var command = e.command;
1262 var target; 1262 var target = assertInstanceof(e.target, HTMLElement);
1263 switch (command.id) { 1263 switch (command.id) {
1264 case 'import-menu-command': 1264 case 'import-menu-command':
1265 recordUserAction('Import'); 1265 recordUserAction('Import');
1266 chrome.bookmarks.import(); 1266 chrome.bookmarks.import();
1267 break; 1267 break;
1268 1268
1269 case 'export-menu-command': 1269 case 'export-menu-command':
1270 recordUserAction('Export'); 1270 recordUserAction('Export');
1271 chrome.bookmarks.export(); 1271 chrome.bookmarks.export();
1272 break; 1272 break;
1273 1273
1274 case 'undo-command': 1274 case 'undo-command':
1275 if (performGlobalUndo) { 1275 if (performGlobalUndo) {
1276 recordUserAction('UndoGlobal'); 1276 recordUserAction('UndoGlobal');
1277 performGlobalUndo(); 1277 performGlobalUndo();
1278 } else { 1278 } else {
1279 recordUserAction('UndoNone'); 1279 recordUserAction('UndoNone');
1280 } 1280 }
1281 break; 1281 break;
1282 1282
1283 case 'show-in-folder-command': 1283 case 'show-in-folder-command':
1284 recordUserAction('ShowInFolder'); 1284 recordUserAction('ShowInFolder');
1285 showInFolder(); 1285 showInFolder();
1286 break; 1286 break;
1287 1287
1288 case 'open-in-new-tab-command': 1288 case 'open-in-new-tab-command':
1289 case 'open-in-background-tab-command': 1289 case 'open-in-background-tab-command':
1290 recordUserAction('OpenInNewTab'); 1290 recordUserAction('OpenInNewTab');
1291 openBookmarks(LinkKind.BACKGROUND_TAB, 1291 openBookmarks(LinkKind.BACKGROUND_TAB, target);
1292 assertInstanceof(e.target, HTMLElement));
1293 break; 1292 break;
1294 1293
1295 case 'open-in-new-window-command': 1294 case 'open-in-new-window-command':
1296 recordUserAction('OpenInNewWindow'); 1295 recordUserAction('OpenInNewWindow');
1297 openBookmarks(LinkKind.WINDOW, 1296 openBookmarks(LinkKind.WINDOW, target);
1298 assertInstanceof(e.target, HTMLElement));
1299 break; 1297 break;
1300 1298
1301 case 'open-incognito-window-command': 1299 case 'open-incognito-window-command':
1302 recordUserAction('OpenIncognito'); 1300 recordUserAction('OpenIncognito');
1303 openBookmarks(LinkKind.INCOGNITO, 1301 openBookmarks(LinkKind.INCOGNITO, target);
1304 assertInstanceof(e.target, HTMLElement));
1305 break; 1302 break;
1306 1303
1307 case 'delete-from-folders-menu-command': 1304 case 'delete-from-folders-menu-command':
1308 target = bmm.tree;
1309 case 'delete-command': 1305 case 'delete-command':
1310 recordUserAction('Delete'); 1306 recordUserAction('Delete');
1311 deleteBookmarks(target || assertInstanceof(e.target, HTMLElement)); 1307 deleteBookmarks(target);
1312 break; 1308 break;
1313 1309
1314 case 'copy-from-folders-menu-command': 1310 case 'copy-from-folders-menu-command':
1315 target = bmm.tree;
1316 case 'copy-command': 1311 case 'copy-command':
1317 recordUserAction('Copy'); 1312 recordUserAction('Copy');
1318 chrome.bookmarkManagerPrivate.copy(getSelectedBookmarkIds(target), 1313 chrome.bookmarkManagerPrivate.copy(getSelectedBookmarkIds(target),
1319 updatePasteCommand); 1314 updatePasteCommand);
1320 break; 1315 break;
1321 1316
1322 case 'cut-from-folders-menu-command': 1317 case 'cut-from-folders-menu-command':
1323 target = bmm.tree;
1324 case 'cut-command': 1318 case 'cut-command':
1325 recordUserAction('Cut'); 1319 recordUserAction('Cut');
1326 chrome.bookmarkManagerPrivate.cut(getSelectedBookmarkIds(target), 1320 chrome.bookmarkManagerPrivate.cut(getSelectedBookmarkIds(target),
1327 function() { 1321 function() {
1328 updatePasteCommand(); 1322 updatePasteCommand();
1329 updateSearchResults(); 1323 updateSearchResults();
1330 }); 1324 });
1331 break; 1325 break;
1332 1326
1333 case 'paste-from-organize-menu-command': 1327 case 'paste-from-organize-menu-command':
1334 pasteBookmark(bmm.list.parentId); 1328 pasteBookmark(bmm.list.parentId);
1335 break; 1329 break;
1336 1330
1337 case 'paste-from-folders-menu-command': 1331 case 'paste-from-folders-menu-command':
1338 pasteBookmark(bmm.tree.selectedItem.bookmarkId); 1332 pasteBookmark(bmm.tree.selectedItem.bookmarkId);
1339 break; 1333 break;
1340 1334
1341 case 'paste-from-context-menu-command': 1335 case 'paste-from-context-menu-command':
1342 pasteBookmark(getSelectedId()); 1336 pasteBookmark(getSelectedId());
1343 break; 1337 break;
1344 1338
1345 case 'sort-command': 1339 case 'sort-command':
1346 recordUserAction('Sort'); 1340 recordUserAction('Sort');
1347 chrome.bookmarkManagerPrivate.sortChildren(bmm.list.parentId); 1341 chrome.bookmarkManagerPrivate.sortChildren(bmm.list.parentId);
1348 break; 1342 break;
1349 1343
1350 case 'rename-folder-command': 1344 case 'rename-folder-command':
1351 editItem(assertInstanceof(e.target, HTMLElement));
1352 break;
1353
1354 case 'rename-folder-from-folders-menu-command': 1345 case 'rename-folder-from-folders-menu-command':
1355 editItem(bmm.tree); 1346 editItem(target);
Bernhard Bauer 2015/04/20 10:28:27 You want to keep this, so that the tree is always
1356 break; 1347 break;
1357 1348
1358 case 'edit-command': 1349 case 'edit-command':
1359 recordUserAction('Edit'); 1350 recordUserAction('Edit');
1360 editItem(); 1351 editItem();
1361 break; 1352 break;
1362 1353
1363 case 'new-folder-from-folders-menu-command': 1354 case 'new-folder-from-folders-menu-command':
1364 target = bmm.tree;
Bernhard Bauer 2015/04/20 10:28:27 You also want to keep this.
1365 case 'new-folder-command': 1355 case 'new-folder-command':
1366 recordUserAction('NewFolder'); 1356 recordUserAction('NewFolder');
1367 newFolder(target); 1357 newFolder(target);
1368 break; 1358 break;
1369 1359
1370 case 'add-new-bookmark-command': 1360 case 'add-new-bookmark-command':
1371 recordUserAction('AddPage'); 1361 recordUserAction('AddPage');
1372 addPage(); 1362 addPage();
1373 break; 1363 break;
1374 1364
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
1519 1509
1520 cr.ui.FocusOutlineManager.forDocument(document); 1510 cr.ui.FocusOutlineManager.forDocument(document);
1521 initializeSplitter(); 1511 initializeSplitter();
1522 bmm.addBookmarkModelListeners(); 1512 bmm.addBookmarkModelListeners();
1523 dnd.init(selectItemsAfterUserAction); 1513 dnd.init(selectItemsAfterUserAction);
1524 bmm.tree.reload(); 1514 bmm.tree.reload();
1525 } 1515 }
1526 1516
1527 initializeBookmarkManager(); 1517 initializeBookmarkManager();
1528 })(); 1518 })();
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698