Create signin component and componentize TokenWebData.

Create signin component and componentize TokenWebData.

This CL creates the signin layered component. It additionally componentizes
TokenWebData and moves it into the signin component. The refactorings performed
on TokenWebData are identical to ones performed on AutofillWebDataService:
- threads are injected rather than being obtained from content::BrowserThread
- //chrome code gets the TokenWebData for a Profile via WebDataServiceFactory
  instead of TokenWebData::FromBrowserContext.

BUG=332107
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243564

[blundell, 2014-01-07 17:20:37]

It begins :).

https://codereview.chromium.org/109783003/diff/1/chrome/browser/signin/mutabl...
File chrome/browser/signin/mutable_profile_oauth2_token_service.cc (right):

https://codereview.chromium.org/109783003/diff/1/chrome/browser/signin/mutabl...
chrome/browser/signin/mutable_profile_oauth2_token_service.cc:86:
WebDataServiceFactory::GetTokenWebDataForProfile(
This class will eventually move into the component, at which point these calls
will be replaced by calls to the embedder (which will implement that call via
this one :).

[tfarina, 2014-01-07 18:17:33]

https://codereview.chromium.org/109783003/diff/40001/components/signin.gypi
File components/signin.gypi (left):

https://codereview.chromium.org/109783003/diff/40001/components/signin.gypi#o...
components/signin.gypi:8: 'target_name': 'metro_utils',
can you adjust your --similarity to make signin.gypi does not look as a copy of
another random file before landing this?

[Roger Tawa OOO till Jul 10th, 2014-01-07 19:50:38]

lgtm

[blundell, 2014-01-08 09:08:34]

https://codereview.chromium.org/109783003/diff/40001/components/signin.gypi
File components/signin.gypi (left):

https://codereview.chromium.org/109783003/diff/40001/components/signin.gypi#o...
components/signin.gypi:8: 'target_name': 'metro_utils',
On 2014/01/07 18:17:34, tfarina wrote:
> can you adjust your --similarity to make signin.gypi does not look as a copy
of
> another random file before landing this?

Done.

[Jói, 2014-01-08 11:02:55]

LGTM with a nit.

https://codereview.chromium.org/109783003/diff/120001/components/signin.gypi
File components/signin.gypi (right):

https://codereview.chromium.org/109783003/diff/120001/components/signin.gypi#...
components/signin.gypi:1: # Copyright 2013 The Chromium Authors. All rights
reserved.
2014

https://codereview.chromium.org/109783003/diff/120001/components/signin/core/...
File components/signin/core/webdata/token_service_table.h (right):

https://codereview.chromium.org/109783003/diff/120001/components/signin/core/...
components/signin/core/webdata/token_service_table.h:16: class TokenServiceTable
: public WebDatabaseTable {
This doesn't need to happen in the current change, but note that code under
//components/signin should be in namespace signin.

[blundell, 2014-01-08 11:52:38]

TBR'ing thakis for change to //chrome/browser/DEPS and //chrome/browser/sync

https://codereview.chromium.org/109783003/diff/120001/components/signin.gypi
File components/signin.gypi (right):

https://codereview.chromium.org/109783003/diff/120001/components/signin.gypi#...
components/signin.gypi:1: # Copyright 2013 The Chromium Authors. All rights
reserved.
On 2014/01/08 11:02:56, Jói wrote:
> 2014

Done.

https://codereview.chromium.org/109783003/diff/120001/components/signin/core/...
File components/signin/core/webdata/token_service_table.h (right):

https://codereview.chromium.org/109783003/diff/120001/components/signin/core/...
components/signin/core/webdata/token_service_table.h:16: class TokenServiceTable
: public WebDatabaseTable {
Yes. My plan is to introduce the namespace at the end of the componentization in
order to minimize churn, as I will be incrementally moving files from //chrome
into the component.

On 2014/01/08 11:02:56, Jói wrote:
> This doesn't need to happen in the current change, but note that code under
> //components/signin should be in namespace signin.

[commit-bot: I haz the power, 2014-01-08 11:53:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/109783003/190001

[commit-bot: I haz the power, 2014-01-08 15:20:08]

Change committed as 243564

[Nico, 2014-01-08 18:43:31]

lgtm

[Noam Samuel, 2014-01-08 22:15:41]

A revert of this CL has been created in
https://codereview.chromium.org/129253003/ by noamsml@chromium.org.

The reason for reverting is: ChromeOS bot failures.