chrome/browser/instant/instant_loader.cc - Issue 10978016: Remove two functions on WebContentsDelegate which didn't belong in content. They were only called f…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_loader.cc

Issue 10978016: Remove two functions on WebContentsDelegate which didn't belong in content. They were only called f… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: don't log history for prerender on android Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | chrome/browser/prerender/prerender_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/instant/instant_loader.cc

===================================================================

--- chrome/browser/instant/instant_loader.cc (revision 158566)

+++ chrome/browser/instant/instant_loader.cc (working copy)

@@ -59,9 +59,6 @@

virtual void HandleGestureEnd() OVERRIDE;

virtual void DragEnded() OVERRIDE;

virtual bool OnGoToEntryOffset(int offset) OVERRIDE;

- virtual bool ShouldAddNavigationToHistory(

- const history::HistoryAddPageArgs& add_page_args,

- content::NavigationType navigation_type) OVERRIDE;

// content::WebContentsObserver:

virtual void DidFinishLoad(

@@ -169,13 +166,6 @@

return false;

}

-bool InstantLoader::WebContentsDelegateImpl::ShouldAddNavigationToHistory(

- const history::HistoryAddPageArgs& add_page_args,

- content::NavigationType navigation_type) {

- loader_->last_navigation_ = add_page_args;

sky 2012/09/25 15:38:48 How come you're removing this? This is the main pl

- return false;

void InstantLoader::WebContentsDelegateImpl::DidFinishLoad(

int64 frame_id,

const GURL& validated_url,