Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3833)

Unified Diff: chrome/browser/instant/instant_loader.h

Issue 10978016: Remove two functions on WebContentsDelegate which didn't belong in content. They were only called f… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_loader.h
===================================================================
--- chrome/browser/instant/instant_loader.h (revision 158566)
+++ chrome/browser/instant/instant_loader.h (working copy)
@@ -38,6 +38,9 @@
// and autocomplete suggestions) between the page and the delegate.
class InstantLoader : public content::NotificationObserver {
public:
+ // Returns the instant loader for |web_contents| if it's used for instant.
sreeram 2012/09/25 22:22:29 instant -> Instant, here and elsewhere in this cha
+ static InstantLoader* FromWebContents(content::WebContents* web_contents);
+
// Creates a new empty WebContents. Use Init() to actually load |instant_url|.
// |tab_contents| is the page the preview will be shown on top of and
// potentially replace. |instant_url| is typically the instant_url field of
@@ -70,6 +73,11 @@
// is a repeat count, negative for moving up, positive for moving down.
void OnUpOrDownKeyPressed(int count);
+ // Called by the history tab helper with the information that it would have
+ // added to the history service had this web contents not been used for
+ // instant.
+ void DidNavigate(const history::HistoryAddPageArgs& add_page_args);
+
// Releases the preview TabContents passing ownership to the caller. This
// should be called when the preview is committed. Notifies the page but not
// the delegate. |text| is the final omnibox text being committed. NOTE: The
@@ -107,6 +115,7 @@
const content::NotificationDetails& details) OVERRIDE;
private:
+ static int kUserDataKey;
sreeram 2012/09/25 22:22:29 It seems like you can stash this in the .cc file (
jam 2012/09/25 22:42:39 Done.
class WebContentsDelegateImpl;
void SetupPreviewContents();

Powered by Google App Engine
This is Rietveld 408576698