Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10978016: Remove two functions on WebContentsDelegate which didn't belong in content. They were only called f… (Closed)

Created:
8 years, 3 months ago by jam
Modified:
8 years, 2 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, browser-components-watch_chromium.org, gideonwald, dcheng, sreeram, groby+watch_chromium.org, ajwong+watch_chromium.org, rouslan+watch_chromium.org, Shishir, joi+watch-content_chromium.org, stevenjb+watch_chromium.org, samarth, dominich, darin-cc_chromium.org, gbillock+watch_chromium.org, Avi (use Gerrit), jennb, creis+watch_chromium.org, jianli, oshima+watch_chromium.org, Jered, Dmitry Titov, David Black, smckay+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove two functions on WebContentsDelegate which didn't belong in content. They were only called from Chrome. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158725

Patch Set 1 #

Patch Set 2 : sync and add missing file #

Patch Set 3 : fix android #

Patch Set 4 : don't log history for prerender on android #

Total comments: 2

Patch Set 5 : #

Total comments: 9

Patch Set 6 : nits and fixed prerender browser tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -124 lines) Patch
M chrome/browser/chromeos/login/web_page_screen.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_screen.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/history/DEPS View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 2 3 4 3 chunks +34 lines, -3 lines 0 comments Download
M chrome/browser/instant/instant_loader.h View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 1 2 3 4 5 8 chunks +33 lines, -11 lines 2 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 2 3 4 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 1 2 3 4 5 3 chunks +7 lines, -21 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 2 3 4 2 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_inline_disposition_delegate.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 2 chunks +0 lines, -8 lines 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/web_dialogs/web_dialog_web_contents_delegate.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jam
8 years, 3 months ago (2012-09-25 07:17:34 UTC) #1
erikwright (departed)
history deps changes LGTM.
8 years, 2 months ago (2012-09-25 15:26:32 UTC) #2
sky
https://codereview.chromium.org/10978016/diff/8009/chrome/browser/instant/instant_loader.cc File chrome/browser/instant/instant_loader.cc (left): https://codereview.chromium.org/10978016/diff/8009/chrome/browser/instant/instant_loader.cc#oldcode175 chrome/browser/instant/instant_loader.cc:175: loader_->last_navigation_ = add_page_args; How come you're removing this? This ...
8 years, 2 months ago (2012-09-25 15:38:47 UTC) #3
jam
Scott: thanks for catching those. ptal Timo: ptal at the chrome/browser/prerender
8 years, 2 months ago (2012-09-25 20:58:16 UTC) #4
tburkard
chrome/browser/prerender: lgtm
8 years, 2 months ago (2012-09-25 21:35:35 UTC) #5
sreeram
(drive-by) https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc File chrome/browser/instant/instant_loader.cc (right): https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc#newcode312 chrome/browser/instant/instant_loader.cc:312: &kUserDataKey, new InstantLoaderUserData(this)); Move this to inside SetupPreviewContents(), ...
8 years, 2 months ago (2012-09-25 22:22:28 UTC) #6
sky
https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc File chrome/browser/instant/instant_loader.cc (right): https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc#newcode30 chrome/browser/instant/instant_loader.cc:30: InstantLoaderUserData(InstantLoader* loader) : loader_(loader) {} explicit https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc#newcode37 chrome/browser/instant/instant_loader.cc:37: }; ...
8 years, 2 months ago (2012-09-25 22:23:18 UTC) #7
jam
https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc File chrome/browser/instant/instant_loader.cc (right): https://codereview.chromium.org/10978016/diff/12007/chrome/browser/instant/instant_loader.cc#newcode30 chrome/browser/instant/instant_loader.cc:30: InstantLoaderUserData(InstantLoader* loader) : loader_(loader) {} On 2012/09/25 22:23:19, sky ...
8 years, 2 months ago (2012-09-25 22:42:39 UTC) #8
sreeram
lgtm for chrome/browser/instant/*. A couple of very minor nits that, if you don't feel like ...
8 years, 2 months ago (2012-09-25 22:51:48 UTC) #9
Greg Billock
On 2012/09/25 22:51:48, sreeram wrote: > lgtm for chrome/browser/instant/*. > > A couple of very ...
8 years, 2 months ago (2012-09-25 23:13:01 UTC) #10
sky
8 years, 2 months ago (2012-09-25 23:41:05 UTC) #11 
LGTM

Powered by Google App Engine
This is Rietveld 408576698