Issue 10978006: Base: disable the scoped handle verifier for M23 beta.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10978006: Base: disable the scoped handle verifier for M23 beta. (Closed)

Created:
8 years, 3 months ago by rvargas (doing something else)

Modified:
8 years, 3 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Base: disable the scoped handle verifier for M23 beta. BUG=152037 TEST=none TBR=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158402

Patch Set 1 #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/win/scoped_handle.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

8 years, 3 months ago (2012-09-24 21:51:47 UTC) #2

lgtm


On Mon, Sep 24, 2012 at 2:48 PM, <rvargas@chromium.org> wrote:

> Reviewers: willchan,
>
> Description:
> Base: disable the scoped handle verifier for M23 beta.
>
> BUG=152037
> TEST=none
> TBR=willchan@chromium.org
>
> Please review this at
http://codereview.chromium.**org/10978006/<http://codereview.chromium.org/109...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     base/win/scoped_handle.h
>
>
> Index: base/win/scoped_handle.h
> ==============================**==============================**=======
> --- base/win/scoped_handle.h    (revision 156854)
> +++ base/win/scoped_handle.h    (working copy)
> @@ -180,7 +180,7 @@
>    DISALLOW_IMPLICIT_**CONSTRUCTORS(VerifierTraits);
>  };
>
> -typedef GenericScopedHandle<**HandleTraits, VerifierTraits> ScopedHandle;
> +typedef GenericScopedHandle<**HandleTraits, DummyVerifierTraits>
> ScopedHandle;
>
>  }  // namespace win
>  }  // namespace base
>
>
>

Expand Messages | Collapse Messages