Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1097773005: Fix components/undo/BUILD.gn (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger, tfarina
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix components/undo/BUILD.gn Change reference to sibling target from absolute to relative to follow the best practices. BUG=476917 Committed: https://crrev.com/8b64a19080bd938333dc69fba0ea1c53d24a162f Cr-Commit-Position: refs/heads/master@{#325833}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/undo/BUILD.gn View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
sdefresne
5 years, 8 months ago (2015-04-20 08:42:58 UTC) #2
droger
This is indeed what I meant in my earlier comment. LGTM
5 years, 8 months ago (2015-04-20 11:40:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097773005/1
5 years, 8 months ago (2015-04-20 12:12:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-20 12:15:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8b64a19080bd938333dc69fba0ea1c53d24a162f Cr-Commit-Position: refs/heads/master@{#325833}
5 years, 8 months ago (2015-04-20 12:15:57 UTC) #7
tfarina
5 years, 8 months ago (2015-04-20 12:41:59 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1097773005/diff/1/components/undo/BUILD.gn
File components/undo/BUILD.gn (right):

https://codereview.chromium.org/1097773005/diff/1/components/undo/BUILD.gn#ne...
components/undo/BUILD.gn:37: ":undo",
I know sort would but this last, but in general we put it at the top before the
other deps.

Powered by Google App Engine
This is Rietveld 408576698