Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1097723005: Lolcode candidate: Both Expression and FunctionLiteral define the same accessor (Closed)

Created:
5 years, 8 months ago by vogelheim
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Lolcode candidate: Both Expression and FunctionLiteral define an accessor is_parenthesized(), which access different flags. FunctionLiteral derives from Expression. Given FunctionLiteral* a; a->is_parenthesized() const FunctionLiteral* b; b->is_parenthesized() the first accesses FunctionLiteral::IsParenthesized, the second accesses Expression::IsParenthesizedField. Since these are distinct uses, we could rename them based on their use: - Expression::is_parenthesized -> is_single_parenthesized Count # of parenthesis, for parsing & error handling: no parenthesis -> single parenthesis -> multi parenthesis - FunctionLiteral::eager_compile_hint() Hint from parser to compiler about whether the parser suggests this function for eager compilation. BUG= Committed: https://crrev.com/63f7fbfea64fc6102a8fad7e570d95976e297d9a Cr-Commit-Position: refs/heads/master@{#28042}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M src/ast.h View 1 8 chunks +16 lines, -19 lines 0 comments Download
M src/compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M src/preparser.h View 1 7 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
vogelheim
5 years, 8 months ago (2015-04-23 17:32:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097723005/1
5 years, 8 months ago (2015-04-23 17:38:45 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/5194) v8_linux_arm64_rel on ...
5 years, 8 months ago (2015-04-23 17:40:06 UTC) #6
Dmitry Lomov (no reviews)
lol indeed. lgtm
5 years, 8 months ago (2015-04-23 18:51:00 UTC) #7
Dmitry Lomov (no reviews)
(C++ is awesome)
5 years, 8 months ago (2015-04-23 18:51:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097723005/20001
5 years, 8 months ago (2015-04-24 11:06:13 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 11:07:56 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 11:08:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63f7fbfea64fc6102a8fad7e570d95976e297d9a
Cr-Commit-Position: refs/heads/master@{#28042}

Powered by Google App Engine
This is Rietveld 408576698