Fix for Ash shortcuts unexpectedly working in system model dialog

ash/accelerators/accelerator_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_table.h"
 
 #include "base/basictypes.h"
 
 namespace ash {
 
@@ skipping 210 matching lines @@
 const size_t kActionsAllowedAtLoginOrLockScreenLength =
     arraysize(kActionsAllowedAtLoginOrLockScreen);
 
 const AcceleratorAction kActionsAllowedAtLockScreen[] = {
   EXIT,
 };
 
 const size_t kActionsAllowedAtLockScreenLength =
     arraysize(kActionsAllowedAtLockScreen);
 
+const AcceleratorAction kActionsAllowedAtModalWindow[] = {

[Yusuke Sato, 2012/09/29 00:54:33]

I'm wondering if it's okay to omit OPEN_FEEDBACK_PAGE. What should the user do
if he/she finds a problem while a modal dialog is up?

[sschmitz, 2012/10/15 23:50:34]

I experimented with this and talked to kuscher@. I will add OPEN_FEEDBACK_PAGE
to the "allow" list. We probably want to take the modal popup down after the
screenshot has been taken in this case.

+  BRIGHTNESS_DOWN,
+  BRIGHTNESS_UP,
+  DISABLE_CAPS_LOCK,
+  EXIT,
+  KEYBOARD_BRIGHTNESS_DOWN,
+  KEYBOARD_BRIGHTNESS_UP,
+  MAGNIFY_SCREEN_ZOOM_IN,
+  MAGNIFY_SCREEN_ZOOM_OUT,
+  MEDIA_NEXT_TRACK,
+  MEDIA_PLAY_PAUSE,
+  MEDIA_PREV_TRACK,
+  NEXT_IME,
+  PREVIOUS_IME,
+  POWER_PRESSED,
+  POWER_RELEASED,
+  PREVIOUS_IME,
+  SHOW_KEYBOARD_OVERLAY,

[Yusuke Sato, 2012/09/29 00:54:33]

does this work fine when a modal window is up? please check if you haven't done
it.

[sschmitz, 2012/10/15 23:50:34]

Yes, it works. 
Done.

+  SWAP_PRIMARY_DISPLAY,

[Yusuke Sato, 2012/09/29 00:54:33]

please also check if this works fine (you might need to connect a secondary
monitor to you chromebook to check it).

[sschmitz, 2012/10/15 23:50:34]

Yes, it works.
Done.

+  SWITCH_IME,
+  TAKE_SCREENSHOT,
+  TAKE_PARTIAL_SCREENSHOT,
+  TOGGLE_CAPS_LOCK,
+  TOGGLE_SPOKEN_FEEDBACK,
+  TOGGLE_WIFI,
+  VOLUME_DOWN,
+  VOLUME_MUTE,
+  VOLUME_UP,
+#if defined(OS_CHROMEOS)
+  CYCLE_DISPLAY_MODE,

[Yusuke Sato, 2012/09/29 00:54:33]

the same.

[sschmitz, 2012/10/15 23:50:34]

Yes, this works. 
Done.

+  LOCK_SCREEN,
+#endif
+};
+
+const size_t kActionsAllowedAtModalWindowLength =
+    arraysize(kActionsAllowedAtModalWindow);
+
 }  // namespace ash