runtime/vm/flow_graph_builder.cc - Issue 10977078: Rename CastException to CastError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 10977078: Rename CastException to CastError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Now without the TODO. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index c067f88633b82bf284f08861ccfaef55a3adaa43..e27565467c8ddb5d7233d9b721da45b3b71421b1 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -794,7 +794,7 @@ void EffectGraphVisitor::BuildTypeCast(ComparisonNode* node) {

ValueGraphVisitor for_value(owner(), temp_index());

node->left()->Visit(&for_value);

const String& dst_name = String::ZoneHandle(

- Symbols::New(Exceptions::kCastExceptionDstName));

+ Symbols::New(Exceptions::kCastErrorDstName));

if (!CanSkipTypeCheck(node->token_pos(), for_value.value(), type, dst_name)) {

Append(for_value);

Do(BuildAssertAssignable(

@@ -879,7 +879,7 @@ void ValueGraphVisitor::BuildTypeCast(ComparisonNode* node) {

node->left()->Visit(&for_value);

Append(for_value);

const String& dst_name = String::ZoneHandle(

- Symbols::New(Exceptions::kCastExceptionDstName));

+ Symbols::New(Exceptions::kCastErrorDstName));

ReturnValue(BuildAssignableValue(node->token_pos(),

for_value.value(),

type,

« no previous file with comments | « runtime/vm/exceptions.cc ('k') | tests/co19/co19-dart2dart.status » ('j') | no next file with comments »