Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: lib/compiler/implementation/lib/js_helper.dart

Issue 10977078: Rename CastException to CastError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Now without the TODO. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/core/errors.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/lib/js_helper.dart
diff --git a/lib/compiler/implementation/lib/js_helper.dart b/lib/compiler/implementation/lib/js_helper.dart
index 3328a759a9bab04aaac5fc799c09d2e1479efc74..b271ad5cd3858f281d4760fdcec08d8ecc57c4d5 100644
--- a/lib/compiler/implementation/lib/js_helper.dart
+++ b/lib/compiler/implementation/lib/js_helper.dart
@@ -1039,7 +1039,7 @@ stringTypeCheck(value) {
stringTypeCast(value) {
if (value is String || value === null) return value;
// TODO(lrn): When reified types are available, pass value.class and String.
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'String');
}
@@ -1051,7 +1051,7 @@ doubleTypeCheck(value) {
doubleTypeCast(value) {
if (value is double || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'double');
}
@@ -1063,7 +1063,7 @@ numTypeCheck(value) {
numTypeCast(value) {
if (value is num || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'num');
}
@@ -1075,7 +1075,7 @@ boolTypeCheck(value) {
boolTypeCast(value) {
if (value is bool || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'bool');
}
@@ -1087,7 +1087,7 @@ functionTypeCheck(value) {
functionTypeCast(value) {
if (value is Function || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'Function');
}
@@ -1099,7 +1099,7 @@ intTypeCheck(value) {
intTypeCast(value) {
if (value is int || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'int');
}
@@ -1113,7 +1113,7 @@ void propertyTypeCastError(value, property) {
// Cuts the property name to the class name.
String actualType = Primitives.objectTypeName(value);
String expectedType = property.substring(3, property.length);
- throw new CastExceptionImplementation(actualType, expectedType);
+ throw new CastErrorImplementation(actualType, expectedType);
}
/**
@@ -1240,7 +1240,7 @@ listTypeCheck(value) {
listTypeCast(value) {
if (value is List || value === null) return value;
- throw new CastExceptionImplementation(
+ throw new CastErrorImplementation(
Primitives.objectTypeName(value), 'List');
}
@@ -1290,17 +1290,17 @@ class TypeErrorImplementation implements TypeError {
}
/** Thrown by the 'as' operator if the cast isn't valid. */
-class CastExceptionImplementation implements CastException {
+class CastErrorImplementation implements CastError {
// TODO(lrn): Rename to CastError (and move implementation into core).
// TODO(lrn): Change actualType and expectedType to "Type" when reified
// types are available.
final Object actualType;
final Object expectedType;
- CastExceptionImplementation(this.actualType, this.expectedType);
+ CastErrorImplementation(this.actualType, this.expectedType);
String toString() {
- return "CastException: Casting value of type $actualType to"
+ return "CastError: Casting value of type $actualType to"
" incompatible type $expectedType";
}
}
« no previous file with comments | « no previous file | lib/core/errors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698